From patchwork Thu Jan 7 17:50:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Das, Nirmoy" X-Patchwork-Id: 12004599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FDA9C433E0 for ; Thu, 7 Jan 2021 17:51:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C596B233FB for ; Thu, 7 Jan 2021 17:50:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C596B233FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08D6F6E4C7; Thu, 7 Jan 2021 17:50:57 +0000 (UTC) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 318BF6E4C5 for ; Thu, 7 Jan 2021 17:50:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkBEkK/s8IKzy3X5F5rxu+MKfhRPoSqbQz4p0pUYg86Dsg41xmupqjOoLAWa3Zk8hVqFOiDoqzqRms172cTD/E7PzA2o6AdT2ayYOB3me5t2V4W2Y9mgFsw2qHVOWwLNunBod6QaV7bCIpHiCIfyqEmSTPWokb0brE9pUxa+8sN2pb5GyZQXHUKi4WJyHdKI/9Yfd53lVVdTXtPj1KnsoOiH2r00R0eveXwVcWRhVRiIYyh+Ar9N1PjzCEJWd5pl6j7CZ+IMLhcoRkSq4BDi7bKYNhb2vLPYjIRXGmAKRXJZ2ms6XSPoHlbpA4Pn2AcD/bdg9NwISewC2BrEXGixBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nqo0XN9w5s1W+dvGkDagPDeomYvgxU34Cpkxni469KM=; b=VFU1o5DBROif/a9UE0VIZ5RMv4x+6sV0bEt9QELiiOde8v8MvTCtPHD1Lywi8qQFPhz6nGKg2Zx5/quiLkA01H2IZlmVTfhJZzVVvxymLmQrxNfehfJTCzK5ekYuSh8zvRFEL5UDebhDSqcvemmTAiGnx9UQcZlbJF1dQ6m4cgq4zdYlup1QaVyFFDpX9B9C3Qh+prMkgvWrGsu59AyvXmhV29rbXllY1/q2GCUWn/76puUdStERWHXVMwoB7HFvoWg26u4z4sMkYQ8t0MmEPM6qbFkTwXTqdA7RJmzOL2Me3TrFq6b/76caCoBLdrecFCWH0z0RI72AmJSLFOCcWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nqo0XN9w5s1W+dvGkDagPDeomYvgxU34Cpkxni469KM=; b=D3PCz7HXFnbSSsxL02L7Fmy1fuUN+tJ7AYc+SX6z/T3Snr3hjKdZ9dBDyDwuMPWfp5DEEsnfCyLhbI9UP9GP0Fu9sHw7efQ9UQVZ2BgFoS2iXHHbrLKx8dWHxNgAMgdCXVI84fSg7UVpCjETG8HGyEGJ9sN96YKgnZYl7s0L0Dw= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB3916.namprd12.prod.outlook.com (2603:10b6:5:1ca::21) by DM6PR12MB3066.namprd12.prod.outlook.com (2603:10b6:5:11a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Thu, 7 Jan 2021 17:50:54 +0000 Received: from DM6PR12MB3916.namprd12.prod.outlook.com ([fe80::f872:3677:28c3:660b]) by DM6PR12MB3916.namprd12.prod.outlook.com ([fe80::f872:3677:28c3:660b%5]) with mapi id 15.20.3721.024; Thu, 7 Jan 2021 17:50:53 +0000 From: Nirmoy Das To: bhelgaas@google.com Subject: [PATCH 4/4] PCI: Add a REBAR size quirk for Sapphire RX 5600 XT Pulse Date: Thu, 7 Jan 2021 18:50:17 +0100 Message-Id: <20210107175017.15893-5-nirmoy.das@amd.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210107175017.15893-1-nirmoy.das@amd.com> References: <20210107175017.15893-1-nirmoy.das@amd.com> X-Originating-IP: [217.86.111.165] X-ClientProxiedBy: AM0PR03CA0093.eurprd03.prod.outlook.com (2603:10a6:208:69::34) To DM6PR12MB3916.namprd12.prod.outlook.com (2603:10b6:5:1ca::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from brihaspati.fritz.box (217.86.111.165) by AM0PR03CA0093.eurprd03.prod.outlook.com (2603:10a6:208:69::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Thu, 7 Jan 2021 17:50:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6963acd3-640f-4aa5-d02f-08d8b334c784 X-MS-TrafficTypeDiagnostic: DM6PR12MB3066: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ArjC5EaHuX8NhcuV3FpOUcFk1GWSRl0lO8HjkVAzp1BeyQsyIot8qQ0EknxqpLwESsfQeOMel3UCqK020tUug3IgTw0o86n1rswjVdspQzaCaF3cuujZ4UOz4cjGsf9IwDzGZQml492TZjAgtWizuxsZ+FEGwbor3eP25tVnwh/D1vQFvi/7SbWXw687v+4LD84Uo6wx0cDLCWZWQUffO75twXnqcHlsLX7xpUxqfxHc19/JYwF/PtdbZJv2TtFNg4CGaMkVrZBQVnecU2K/Q3FGuz0Ara+JVgt7/r/XtsRnIXrK+WcncO132V1fy8l+eW9kApQtkjZ1bPQhdXe3UW07B5pROZUEYFU38eZVZ7i1SQleNMk9G1HyQu0McWR0XN/TCeBkHhAAPRihgZyBJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3916.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(4326008)(6916009)(316002)(1076003)(66574015)(83380400001)(478600001)(6486002)(54906003)(36756003)(26005)(66476007)(66556008)(5660300002)(8936002)(66946007)(2616005)(16526019)(44832011)(2906002)(52116002)(6506007)(8676002)(86362001)(6666004)(956004)(6512007)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?6put+sMivubgGJf7J9TE/AaZ5yQ4dp?= =?utf-8?q?DEl7E+dj3nQROkuRN9KAQ210IQjRb33ZsR/YxgmLnEaBxzT6Eeg05q2ySCgHX8IyC?= =?utf-8?q?WD/H3E5X19GrXvz3Unkf2VMsYoLNOgfdNka0Z2YECKFcTyhmgffnWFtcxXF8k+ZJ0?= =?utf-8?q?eXVcRskGvecyPikqLUSquj1e62X0aGuv0Ygi7ECekaH3iCx9N0jWIWX5Z/kPqIZla?= =?utf-8?q?oRtbuIyPOHYQ68B9KD+pzQTW+UrPiV9Z+6jL7Gf6ubDeMZCsgJF3TyuYBwL/jJwuL?= =?utf-8?q?T0ZkJm7ynbj9Gs8Gw1aSvOdIWikXsWF9IAXsd/XLNYOC9kd9sE/n/pyzgB6if+z3s?= =?utf-8?q?AgQZ8wP6d7xIb93zpxneT3ppMjJ2H4GR//TT8/ww6jGM8XD0FBv2gWkuTDvd0WmGU?= =?utf-8?q?vZ1VNYh9+JaAoi+AQ0TL/w9odsZzm/nSnR1XpRmEcc6B30V0aeZMB31Be3nGfz2wb?= =?utf-8?q?DVhqgHuxdwAB4qvT907gIS/fMUrKFrdM8CNE6GS5FesiKtf/TQcDi1lic4lQGRYO9?= =?utf-8?q?gu7ehC7ivLvkOQr+eFFbBiWtzh4g99YJwlWCULOnScgqKsIqhbQ4Y4yZXHuow0sx2?= =?utf-8?q?rh73lLwxGMPiPyYJSbAGZHnPTGVQU/g7o0C8VEgRZvey/g2UMFsJ/bcFAzEOEcTFs?= =?utf-8?q?d/vtVFIqU5eg2qgMCTXPN2PU/BeBMDQuHDvCZjWg3TKizQX51m7kTSw9GyABHXdDA?= =?utf-8?q?t4v7Nb/gMvEVr/8SDUhAx3Ey7z0aZDoBvbbyG4ufsesuKygr02POCFSAIFwmH8KE0?= =?utf-8?q?6jKygN9Ht0294jLUKeE86a0ZHAo1bAg0ci/4LG6BISxLhcKIOZ3rB4OMOCFtsMuy2?= =?utf-8?q?QLWSNBQCLb9kvGe9YlGi1ZKAxOy96/FC8m/dtIxNZWtnRR5myEHzvWWnTRdXqCSBx?= =?utf-8?q?AZ823Y0FjNWgLFSiXPc8TeDAm8eQYzpgCmK3M6bC786Z1ZpKACsmoiJDMRKAM0Oed?= =?utf-8?q?+7LPA6k0h8S9UAp6xLy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3916.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2021 17:50:53.8637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: 6963acd3-640f-4aa5-d02f-08d8b334c784 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fHVbAVxDIg4R1MvrgQZwjAMxiMiw2VDOpH6+8oIzRYQlxYlNfx67AkJ+ENvasg0R9VJVAb3v2+0pfOd5RWQP+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3066 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , ckoenig.leichtzumerken@gmail.com, dri-devel@lists.freedesktop.org, Nirmoy Das , linux-pci@vger.kernel.org, devspam@moreofthesa.me.uk, =?utf-8?q?Christian_K?= =?utf-8?q?=C3=B6nig?= , Dan Carpenter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RX 5600 XT Pulse advertises support for BAR0 being 256MB, 512MB, or 1GB, but it also supports 2GB, 4GB, and 8GB. Add a rebar size quirk so that CPU can fully access the BAR0. Signed-off-by: Christian König Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Nirmoy Das Acked-by: Bjorn Helgaas --- drivers/pci/pci.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 16216186b51c..b061bbd4afb1 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3577,7 +3577,14 @@ u32 pci_rebar_get_possible_sizes(struct pci_dev *pdev, int bar) return 0; pci_read_config_dword(pdev, pos + PCI_REBAR_CAP, &cap); - return (cap & PCI_REBAR_CAP_SIZES) >> 4; + cap = (cap & PCI_REBAR_CAP_SIZES) >> 4; + + /* Sapphire RX 5600 XT Pulse has an invalid cap dword for BAR 0 */ + if (pdev->vendor == PCI_VENDOR_ID_ATI && pdev->device == 0x731f && + bar == 0 && cap == 0x700) + cap = 0x3f00; + + return cap; } EXPORT_SYMBOL(pci_rebar_get_possible_sizes);