diff mbox series

[1/1] drm/amdgpu: Remove unused variable

Message ID 20210112174633.77125-1-nirmoy.das@amd.com (mailing list archive)
State New, archived
Headers show
Series [1/1] drm/amdgpu: Remove unused variable | expand

Commit Message

Das, Nirmoy Jan. 12, 2021, 5:46 p.m. UTC
Remove unused space_needed variable.

Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alex Deucher Jan. 12, 2021, 9:38 p.m. UTC | #1
On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das <nirmoy.das@amd.com> wrote:
>
> Remove unused space_needed variable.
>
> Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 348ac678a230..5888367b1000 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
>   */
>  int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
>  {
> -       u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>         int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
>         struct pci_bus *root;
>         struct resource *res;
> --
> 2.29.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Christian König Jan. 13, 2021, 2:13 p.m. UTC | #2
Am 12.01.21 um 22:38 schrieb Alex Deucher:
> On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das <nirmoy.das@amd.com> wrote:
>> Remove unused space_needed variable.
>>
>> Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Have you already pushed this to drm-misc-next or should I take care of this?

Christian.

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 348ac678a230..5888367b1000 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -1106,7 +1106,6 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
>>    */
>>   int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
>>   {
>> -       u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
>>          int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
>>          struct pci_bus *root;
>>          struct resource *res;
>> --
>> 2.29.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=04%7C01%7CChristian.Koenig%40amd.com%7C55c33bd6f6874a973bff08d8b742783e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637460843402778720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=yizQB3RyltggTngn047YcPSDW3rFOTHffuVtDY3k3mI%3D&amp;reserved=0
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 348ac678a230..5888367b1000 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1106,7 +1106,6 @@  void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
  */
 int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
 {
-	u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
 	int rbar_size = pci_rebar_bytes_to_size(adev->gmc.real_vram_size);
 	struct pci_bus *root;
 	struct resource *res;