From patchwork Sat Apr 24 00:12:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 12222073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7AA0C433ED for ; Sat, 24 Apr 2021 00:12:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8741F61396 for ; Sat, 24 Apr 2021 00:12:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8741F61396 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1AED6E039; Sat, 24 Apr 2021 00:12:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by gabe.freedesktop.org (Postfix) with ESMTPS id 677B06E039 for ; Sat, 24 Apr 2021 00:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=sJ6mzEzOm3NtSuCM8j9or/o9X3YIjUZaA6m4E9jOXWA=; b=LJ2SxMxTYdweqHZvQfIx6eSPjD 9ysOshNKGd/B6hZnOxqol5DT9WkZOvWzBei5+Qwgfco7CfTVjKx0nVFMxr7H3RR8IRmPlUMlRiCY7 itFWdiJpvfct0n97L4VzjALVGSX3iF+hCRSDX9mhfPw5tqhoSm0oHstmJs429HeXoIRs/r7Spnvt7 t4RAHO1JUqocmrl1pFNyCJuix6J0vm9ni/VeeKM27Op3nC4ICnKPJ/GwQ/QyOhwwTbKAi8O2aLzQy gtBKqfGIYpJ/Lyy2KaSpJFCaGWPNvTc0ylpDlKyx9M096PiQtJIiZ0PUwUMma9mHO9A5OnWspjMNC iCJu+uHA==; Received: from [2601:1c0:6280:3f0::df68] (helo=smtpauth.infradead.org) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1la5uD-002ds2-Rp; Sat, 24 Apr 2021 00:12:18 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [PATCH v2] drm: rcar-du: fix linker undefined references Date: Fri, 23 Apr 2021 17:12:14 -0700 Message-Id: <20210424001214.30642-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , Masahiro Yamada , Randy Dunlap , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jacopo Mondi , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When DRM_RCAR_DU=y and DRM_RCAR_LVDS=m, there are several build errors as reported by 'kernel test robot'. These can be corrected by changing source code occurrences of IS_ENABLED(...) to IS_REACHABLE(...). In looking at this, the same problem (build errors) happens when DRM_RCAR_DU=y and DRM_RCAR_CMM=m, so again change an IS_ENABLED() to IS_REACHABLE() for this case as well. These changes fix the following 8 build/link errors: aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': rcar_du_crtc.c:(.text+0x1be8): undefined reference to `rcar_lvds_clk_enable' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': rcar_du_crtc.c:(.text+0x2438): undefined reference to `rcar_lvds_clk_disable' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_drv.o: in function `rcar_du_init': rcar_du_drv.c:(.init.text+0x14): undefined reference to `rcar_du_of_init' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_encoder.o: in function `rcar_du_encoder_init': rcar_du_encoder.c:(.text+0x1d4): undefined reference to `rcar_lvds_dual_link' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_cmm_setup': rcar_du_crtc.c:(.text+0x380): undefined reference to `rcar_cmm_setup' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_enable': rcar_du_crtc.c:(.text+0x1c08): undefined reference to `rcar_cmm_enable' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function `rcar_du_crtc_atomic_disable': rcar_du_crtc.c:(.text+0x231c): undefined reference to `rcar_cmm_disable' aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_kms.o: in function `rcar_du_modeset_init': rcar_du_kms.c:(.text+0xd08): undefined reference to `rcar_cmm_init' All RCAR kconfig combinations now build for me. Fixes: e08e934d6c28 ("drm: rcar-du: Add support for CMM") Fixes: 02f2b30032c1 ("drm: rcar-du: lvds: Add API to enable/disable clock output") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Masahiro Yamada Cc: Laurent Pinchart Cc: Kieran Bingham Cc: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org Cc: Jacopo Mondi --- v2: also send to LKML; don't change Kconfig "imply" to "select" since not all platforms with DU have CMM and/or LVDS support. Use IS_REACHABLE() instead. drivers/gpu/drm/rcar-du/rcar_cmm.h | 4 ++-- drivers/gpu/drm/rcar-du/rcar_du_of.h | 2 +- drivers/gpu/drm/rcar-du/rcar_lvds.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) --- linux-next-20210420.orig/drivers/gpu/drm/rcar-du/rcar_lvds.h +++ linux-next-20210420/drivers/gpu/drm/rcar-du/rcar_lvds.h @@ -12,7 +12,7 @@ struct drm_bridge; -#if IS_ENABLED(CONFIG_DRM_RCAR_LVDS) +#if IS_REACHABLE(CONFIG_DRM_RCAR_LVDS) int rcar_lvds_clk_enable(struct drm_bridge *bridge, unsigned long freq); void rcar_lvds_clk_disable(struct drm_bridge *bridge); bool rcar_lvds_dual_link(struct drm_bridge *bridge); --- linux-next-20210420.orig/drivers/gpu/drm/rcar-du/rcar_du_of.h +++ linux-next-20210420/drivers/gpu/drm/rcar-du/rcar_du_of.h @@ -11,7 +11,7 @@ struct of_device_id; -#if IS_ENABLED(CONFIG_DRM_RCAR_LVDS) +#if IS_REACHABLE(CONFIG_DRM_RCAR_LVDS) void __init rcar_du_of_init(const struct of_device_id *of_ids); #else static inline void rcar_du_of_init(const struct of_device_id *of_ids) { } --- linux-next-20210420.orig/drivers/gpu/drm/rcar-du/rcar_cmm.h +++ linux-next-20210420/drivers/gpu/drm/rcar-du/rcar_cmm.h @@ -25,7 +25,7 @@ struct rcar_cmm_config { } lut; }; -#if IS_ENABLED(CONFIG_DRM_RCAR_CMM) +#if IS_REACHABLE(CONFIG_DRM_RCAR_CMM) int rcar_cmm_init(struct platform_device *pdev); int rcar_cmm_enable(struct platform_device *pdev); @@ -53,6 +53,6 @@ static inline int rcar_cmm_setup(struct { return 0; } -#endif /* IS_ENABLED(CONFIG_DRM_RCAR_CMM) */ +#endif /* IS_REACHABLE(CONFIG_DRM_RCAR_CMM) */ #endif /* __RCAR_CMM_H__ */