diff mbox series

[1/1] drm/vmwgfx: use ttm_bo_move_null() when there is nothing to move

Message ID 20210608181306.90008-1-nirmoy.das@amd.com (mailing list archive)
State New, archived
Headers show
Series [1/1] drm/vmwgfx: use ttm_bo_move_null() when there is nothing to move | expand

Commit Message

Das, Nirmoy June 8, 2021, 6:13 p.m. UTC
Use ttm_bo_move_null() instead of ttm_bo_assign_mem().

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christian König June 9, 2021, 6:38 a.m. UTC | #1
Am 08.06.21 um 20:13 schrieb Nirmoy Das:
> Use ttm_bo_move_null() instead of ttm_bo_assign_mem().
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>

Looks like I've forgot to push that one. *sigh* I'm getting old.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> index bfcf31bf7e37..0488042fb287 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> @@ -733,7 +733,7 @@ static int vmw_move(struct ttm_buffer_object *bo,
>   
>   	if (old_man->use_tt && new_man->use_tt) {
>   		if (bo->resource->mem_type == TTM_PL_SYSTEM) {
> -			ttm_bo_assign_mem(bo, new_mem);
> +			ttm_bo_move_null(bo, new_mem);
>   			return 0;
>   		}
>   		ret = ttm_bo_wait_ctx(bo, ctx);
Das, Nirmoy June 9, 2021, 9:05 a.m. UTC | #2
On 6/9/2021 8:38 AM, Christian König wrote:
> Am 08.06.21 um 20:13 schrieb Nirmoy Das:
>> Use ttm_bo_move_null() instead of ttm_bo_assign_mem().
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Looks like I've forgot to push that one. *sigh* I'm getting old.


Nah, you have too many stuff on your plate. I should've pinged.


Regards,

Nirmoy


>
> Thanks,
> Christian.
>
>> ---
>>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c 
>> b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> index bfcf31bf7e37..0488042fb287 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
>> @@ -733,7 +733,7 @@ static int vmw_move(struct ttm_buffer_object *bo,
>>         if (old_man->use_tt && new_man->use_tt) {
>>           if (bo->resource->mem_type == TTM_PL_SYSTEM) {
>> -            ttm_bo_assign_mem(bo, new_mem);
>> +            ttm_bo_move_null(bo, new_mem);
>>               return 0;
>>           }
>>           ret = ttm_bo_wait_ctx(bo, ctx);
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
index bfcf31bf7e37..0488042fb287 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
@@ -733,7 +733,7 @@  static int vmw_move(struct ttm_buffer_object *bo,
 
 	if (old_man->use_tt && new_man->use_tt) {
 		if (bo->resource->mem_type == TTM_PL_SYSTEM) {
-			ttm_bo_assign_mem(bo, new_mem);
+			ttm_bo_move_null(bo, new_mem);
 			return 0;
 		}
 		ret = ttm_bo_wait_ctx(bo, ctx);