| Message ID | 20210815192959.90142-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/radeon: Add break to switch statement in radeonfb_create_pinned_object() | expand |
Am 15.08.21 um 21:29 schrieb Nathan Chancellor: > Clang + -Wimplicit-fallthrough warns: > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated > fall-through between switch labels [-Wimplicit-fallthrough] > default: > ^ > drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid > fall-through > default: > ^ > break; > 1 warning generated. > > Clang's version of this warning is a little bit more pedantic than > GCC's. Add the missing break to satisfy it to match what has been done > all over the kernel tree. > > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/radeon/radeon_fb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c > index 0b206b052972..c8b545181497 100644 > --- a/drivers/gpu/drm/radeon/radeon_fb.c > +++ b/drivers/gpu/drm/radeon/radeon_fb.c > @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev, > break; > case 2: > tiling_flags |= RADEON_TILING_SWAP_16BIT; > + break; > default: > break; > } > > base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f
Applied. Thanks! Alex On Mon, Aug 16, 2021 at 3:23 AM Christian König <christian.koenig@amd.com> wrote: > > Am 15.08.21 um 21:29 schrieb Nathan Chancellor: > > Clang + -Wimplicit-fallthrough warns: > > > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated > > fall-through between switch labels [-Wimplicit-fallthrough] > > default: > > ^ > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid > > fall-through > > default: > > ^ > > break; > > 1 warning generated. > > > > Clang's version of this warning is a little bit more pedantic than > > GCC's. Add the missing break to satisfy it to match what has been done > > all over the kernel tree. > > > > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > > Reviewed-by: Christian König <christian.koenig@amd.com> > > > --- > > drivers/gpu/drm/radeon/radeon_fb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c > > index 0b206b052972..c8b545181497 100644 > > --- a/drivers/gpu/drm/radeon/radeon_fb.c > > +++ b/drivers/gpu/drm/radeon/radeon_fb.c > > @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev, > > break; > > case 2: > > tiling_flags |= RADEON_TILING_SWAP_16BIT; > > + break; > > default: > > break; > > } > > > > base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f >
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index 0b206b052972..c8b545181497 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev, break; case 2: tiling_flags |= RADEON_TILING_SWAP_16BIT; + break; default: break; }
Clang + -Wimplicit-fallthrough warns: drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid fall-through default: ^ break; 1 warning generated. Clang's version of this warning is a little bit more pedantic than GCC's. Add the missing break to satisfy it to match what has been done all over the kernel tree. Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/gpu/drm/radeon/radeon_fb.c | 1 + 1 file changed, 1 insertion(+) base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f