| Message ID | 20210824181140.v2.1.I8ead7431357409f2526e5739ec5bc3ddfd242243@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/bridge: parade-ps8640: Reorg the macros | expand |
On Tue, Aug 24, 2021 at 06:11:55PM -0700, Philip Chen wrote: > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the number of mipi data lanes. > > Signed-off-by: Philip Chen <philipchen@chromium.org> Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > > Changes in v2: > - Fix the double sign-off lines > > drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c > index 7bd0affa057a..685e9c38b2db 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -18,16 +18,18 @@ > #include <drm/drm_print.h> > > #define PAGE2_GPIO_H 0xa7 > -#define PS_GPIO9 BIT(1) > +#define PS_GPIO9 BIT(1) > #define PAGE2_I2C_BYPASS 0xea > -#define I2C_BYPASS_EN 0xd0 > +#define I2C_BYPASS_EN 0xd0 > #define PAGE2_MCS_EN 0xf3 > -#define MCS_EN BIT(0) > +#define MCS_EN BIT(0) > + > #define PAGE3_SET_ADD 0xfe > -#define VDO_CTL_ADD 0x13 > -#define VDO_DIS 0x18 > -#define VDO_EN 0x1c > -#define DP_NUM_LANES 4 > +#define VDO_CTL_ADD 0x13 > +#define VDO_DIS 0x18 > +#define VDO_EN 0x1c > + > +#define NUM_MIPI_LANES 4 > > /* > * PS8640 uses multiple addresses: > @@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > MIPI_DSI_MODE_VIDEO_SYNC_PULSE; > dsi->format = MIPI_DSI_FMT_RGB888; > - dsi->lanes = DP_NUM_LANES; > + dsi->lanes = NUM_MIPI_LANES; > ret = mipi_dsi_attach(dsi); > if (ret) > goto err_dsi_attach; > -- > 2.33.0.rc2.250.ged5fa647cd-goog
Quoting Philip Chen (2021-08-24 18:11:55) > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the number of mipi data lanes. > > Signed-off-by: Philip Chen <philipchen@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Hi, On Tue, Aug 24, 2021 at 6:12 PM Philip Chen <philipchen@chromium.org> wrote: > > Reorg the macros as follows: > (1) Group the registers on the same page together. > (2) Group the register and its bit operation together while indenting > the macros of the bit operation with one space. > > Also fix a misnomer for the number of mipi data lanes. > > Signed-off-by: Philip Chen <philipchen@chromium.org> > --- > > Changes in v2: > - Fix the double sign-off lines > > drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Pushed to drm-misc-next with Sam's Ack and Stephen's review. 28210a3f5412 drm/bridge: parade-ps8640: Reorg the macros -Doug
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 7bd0affa057a..685e9c38b2db 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -18,16 +18,18 @@ #include <drm/drm_print.h> #define PAGE2_GPIO_H 0xa7 -#define PS_GPIO9 BIT(1) +#define PS_GPIO9 BIT(1) #define PAGE2_I2C_BYPASS 0xea -#define I2C_BYPASS_EN 0xd0 +#define I2C_BYPASS_EN 0xd0 #define PAGE2_MCS_EN 0xf3 -#define MCS_EN BIT(0) +#define MCS_EN BIT(0) + #define PAGE3_SET_ADD 0xfe -#define VDO_CTL_ADD 0x13 -#define VDO_DIS 0x18 -#define VDO_EN 0x1c -#define DP_NUM_LANES 4 +#define VDO_CTL_ADD 0x13 +#define VDO_DIS 0x18 +#define VDO_EN 0x1c + +#define NUM_MIPI_LANES 4 /* * PS8640 uses multiple addresses: @@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE; dsi->format = MIPI_DSI_FMT_RGB888; - dsi->lanes = DP_NUM_LANES; + dsi->lanes = NUM_MIPI_LANES; ret = mipi_dsi_attach(dsi); if (ret) goto err_dsi_attach;
Reorg the macros as follows: (1) Group the registers on the same page together. (2) Group the register and its bit operation together while indenting the macros of the bit operation with one space. Also fix a misnomer for the number of mipi data lanes. Signed-off-by: Philip Chen <philipchen@chromium.org> --- Changes in v2: - Fix the double sign-off lines drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)