diff mbox series

[2/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

Message ID 20211006074713.1094396-2-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support | expand

Commit Message

Alexander Stein Oct. 6, 2021, 7:47 a.m. UTC 
Add a VCC regulator which needs to be enabled before the EN pin is
released.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml     | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Sam Ravnborg Oct. 11, 2021, 8:30 p.m. UTC | #1 
On Wed, Oct 06, 2021 at 09:47:12AM +0200, Alexander Stein wrote:
> Add a VCC regulator which needs to be enabled before the EN pin is
> released.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Looks good,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

When you resend please put bindings patches first, we should not commit
code changes that uses undocumented bindings. On principle.

	Sam
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index 07b20383cbca..149cff3233c2 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -32,6 +32,9 @@  properties:
     maxItems: 1
     description: GPIO specifier for bridge_en pin (active high).
 
+  vcc-supply:
+    description: A 1.8V power supply (see regulator/regulator.yaml).
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
@@ -94,6 +97,7 @@  required:
   - compatible
   - reg
   - enable-gpios
+  - vcc-supply
   - ports
 
 allOf:
@@ -135,6 +139,7 @@  examples:
             reg = <0x2d>;
 
             enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
+            vcc-supply = <&reg_sn65dsi83_1v8>;
 
             ports {
                 #address-cells = <1>;