From patchwork Tue Oct 12 06:48:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12551577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35307C433EF for ; Tue, 12 Oct 2021 06:54:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02926608FE for ; Tue, 12 Oct 2021 06:54:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 02926608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4B6A6E5BE; Tue, 12 Oct 2021 06:54:28 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC01B89F49 for ; Tue, 12 Oct 2021 06:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634021346; x=1665557346; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PRVemg1TCgZgqoh2zDWu0Su4fQCkOIKQ3XhFew+ehD8=; b=R+gcHYNPK6v5kCDMgMt3wKALrtha9jDRINJiggIp77niapB4YuiAwYxJ eiWEZqwFcQzAuOE9Qr8uGC3Tt2aNKJ0b+EcTLS2wlVNxJ53r8GDrnAzUi ZSr7MLWEr5g234MyaIICVTWcu8lj1fPxcEx/un4PythuTi14/7uiiQ/KR zaePDjyS3rbfaomoYEOc1zmwldOS2slRYSyPqz9woeyOcTh1nN5SsYQCG 4yJteVjo3vwLUnjSXixajo4O2hEQXjEQp2Fdnf0OvaC9KnawzADaGKPP1 fU1rnvphDJgl+0vUY1Bex3OjIXxlPpb1POTWq74zDqcGzeftNCbGhn0oG A==; X-IronPort-AV: E=Sophos;i="5.85,366,1624312800"; d="scan'208";a="19985098" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 12 Oct 2021 08:49:02 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 12 Oct 2021 08:49:02 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 12 Oct 2021 08:49:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1634021342; x=1665557342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PRVemg1TCgZgqoh2zDWu0Su4fQCkOIKQ3XhFew+ehD8=; b=kx3Z9JCGDK89LGpC+sHjVIDPofRGv5NGqipgpbJFW+YFIH58R87/lkb8 tJHMLeGISZlBJ125b1XBPS4TXfXITxYHLoQ2fU6BesVKuflHRuWPPVLl8 JE3CcM49YT7w0LjXbdfmW20PwGUvoFXvOmqCHV9LiZLHiVP/El1x1f/0K 5cWCGuPz8UQVhl4n2bEHBbPBvmPlNqVP5CxtPA7NMl9OLWedg6xqjWD37 ae3D7XWb2UuznVrMH3U1KM5roMCOrymmHw22EJYtMynaHQ0dPsPUNt9Oc OUvjrg46WUFZlJC+GvfPhnVH+5rOOhlcn9YLRVaZbdHGsp6KWG9vMHCcs A==; X-IronPort-AV: E=Sophos;i="5.85,366,1624312800"; d="scan'208";a="19985097" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 12 Oct 2021 08:49:02 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 30EA0280065; Tue, 12 Oct 2021 08:49:02 +0200 (CEST) From: Alexander Stein To: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Alexander Stein , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Sam Ravnborg Subject: [PATCH v2 4/4] drm/bridge: ti-sn65dsi83: Add vcc supply regulator support Date: Tue, 12 Oct 2021 08:48:43 +0200 Message-Id: <20211012064843.298104-5-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211012064843.298104-1-alexander.stein@ew.tq-group.com> References: <20211012064843.298104-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 12 Oct 2021 06:54:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VCC needs to be enabled before releasing the enable GPIO. Reviewed-by: Sam Ravnborg Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 9072342566f3..a6b1fd71dfee 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include @@ -143,6 +144,7 @@ struct sn65dsi83 { struct mipi_dsi_device *dsi; struct drm_bridge *panel_bridge; struct gpio_desc *enable_gpio; + struct regulator *vcc; int dsi_lanes; bool lvds_dual_link; bool lvds_dual_link_even_odd_swap; @@ -647,6 +649,12 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model) ctx->panel_bridge = panel_bridge; + ctx->vcc = devm_regulator_get(dev, "vcc"); + if (IS_ERR(ctx->vcc)) + return dev_err_probe(dev, PTR_ERR(ctx->vcc), + "Failed to get supply 'vcc': %pe\n", + ctx->vcc); + return 0; } @@ -691,7 +699,11 @@ static int sn65dsi83_probe(struct i2c_client *client, ctx->bridge.of_node = dev->of_node; drm_bridge_add(&ctx->bridge); - return 0; + ret = regulator_enable(ctx->vcc); + if (ret) + dev_err(dev, "Failed to enable vcc: %i\n", ret); + + return ret; } static int sn65dsi83_remove(struct i2c_client *client) @@ -702,6 +714,7 @@ static int sn65dsi83_remove(struct i2c_client *client) mipi_dsi_device_unregister(ctx->dsi); drm_bridge_remove(&ctx->bridge); of_node_put(ctx->host_node); + regulator_disable(ctx->vcc); return 0; }