| Message ID | 20211104102035.243305-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: parade-ps8640: Assign drm_device to dp aux channel | expand |
On 04.11.21 12:20, AngeloGioacchino Del Regno wrote: > As it was done with other bridge drivers and to solve a warning coming > from drm_dp_aux_register(), add a backpointer to drm_device in the > drm_dp_aux that we're registering. > it is common to dump the exact warning in the commit log so people can locate it later. Maybe also add 'Fixes' tag? apart of that Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/bridge/parade-ps8640.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c > index 191cc196c9d1..20d8e606d543 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, > goto err_dsi_attach; > } > > + ps_bridge->aux.drm_dev = bridge->dev; > ret = drm_dp_aux_register(&ps_bridge->aux); > if (ret) { > dev_err(dev, "failed to register DP AUX channel: %d\n", ret); >
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 191cc196c9d1..20d8e606d543 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge, goto err_dsi_attach; } + ps_bridge->aux.drm_dev = bridge->dev; ret = drm_dp_aux_register(&ps_bridge->aux); if (ret) { dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
As it was done with other bridge drivers and to solve a warning coming from drm_dp_aux_register(), add a backpointer to drm_device in the drm_dp_aux that we're registering. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/gpu/drm/bridge/parade-ps8640.c | 1 + 1 file changed, 1 insertion(+)