diff mbox series

dt-bindings: panel: Include SPI peripheral properties

Message ID 20211203154350.179112-1-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: panel: Include SPI peripheral properties | expand

Commit Message

Thierry Reding Dec. 3, 2021, 3:43 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

SPI panels need to reference the SPI peripheral properties so that they
can be properly validated.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 .../devicetree/bindings/display/panel/lgphilips,lb035q02.yaml    | 1 +
 .../devicetree/bindings/display/panel/sony,acx565akm.yaml        | 1 +
 2 files changed, 2 insertions(+)

Comments

Rob Herring Dec. 3, 2021, 6:05 p.m. UTC | #1
On Fri, Dec 3, 2021 at 9:43 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> SPI panels need to reference the SPI peripheral properties so that they
> can be properly validated.

Thanks for doing this.

>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../devicetree/bindings/display/panel/lgphilips,lb035q02.yaml    | 1 +
>  .../devicetree/bindings/display/panel/sony,acx565akm.yaml        | 1 +
>  2 files changed, 2 insertions(+)

I'm seeing a few more than this. If there's some logic to the ones you
fixed, I'm not seeing it.

Documentation/devicetree/bindings/display/st,stm32-dsi.example.dt.yaml:
dsi@5a000000: Unevaluated properties are not allowed ('panel-dsi@0'
was unexpected)
Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml:
lcd@0: Unevaluated properties are not allowed ('#address-cells',
'#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were
unexpected)
Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('spi-max-frequency',
'spi-3wire' were unexpected)
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml:
display@0: Unevaluated properties are not allowed ('reg' was
unexpected)
Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml:
display@0: Unevaluated properties are not allowed ('spi-max-frequency'
was unexpected)
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('spi-max-frequency'
was unexpected)
Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml:
panel@2: Unevaluated properties are not allowed ('spi-max-frequency',
'reg' were unexpected)
Documentation/devicetree/bindings/display/panel/novatek,nt36672a.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('vddi0-supply',
'#address-cells', '#size-cells' were unexpected)
Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('reg',
'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('spi-max-frequency',
'spi-cpol', 'spi-cpha' were unexpected)
Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('spi-max-frequency'
was unexpected)
Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml:
panel@0: Unevaluated properties are not allowed ('spi-max-frequency',
'spi-cpol', 'spi-cpha' were unexpected)

>
> diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
> index 830e335ddb53..240a884b7fa7 100644
> --- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
> @@ -14,6 +14,7 @@ maintainers:
>    - Tomi Valkeinen <tomi.valkeinen@ti.com>
>
>  allOf:
> +  - $ref: ../../spi/spi-peripheral-props.yaml

Please use /schemas/spi/... instead.

This needs Mark's tree if you want to avoid errors. I'm fine though as
long as linux-next is okay. Or I can pull in Mark's tree and take this
and others.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
index 830e335ddb53..240a884b7fa7 100644
--- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
@@ -14,6 +14,7 @@  maintainers:
   - Tomi Valkeinen <tomi.valkeinen@ti.com>
 
 allOf:
+  - $ref: ../../spi/spi-peripheral-props.yaml
   - $ref: panel-common.yaml#
 
 properties:
diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
index 95d053c548ab..4459d746592f 100644
--- a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
@@ -14,6 +14,7 @@  maintainers:
   - Tomi Valkeinen <tomi.valkeinen@ti.com>
 
 allOf:
+  - $ref: ../../spi/spi-peripheral-props.yaml
   - $ref: panel-common.yaml#
 
 properties: