From patchwork Sun Jan 23 20:43:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 12721203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AABE0C433F5 for ; Sun, 23 Jan 2022 20:52:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0F1E10E22B; Sun, 23 Jan 2022 20:52:30 +0000 (UTC) X-Greylist: delayed 456 seconds by postgrey-1.36 at gabe; Sun, 23 Jan 2022 20:52:29 UTC Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id D865210E22B for ; Sun, 23 Jan 2022 20:52:29 +0000 (UTC) Received: from localhost.localdomain (ip-213-127-106-2.ip.prioritytelecom.net [213.127.106.2]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id E2DEDCE792; Sun, 23 Jan 2022 20:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1642970692; bh=Pz8Rr0gE1WWTUWJgZZYIwX9EYZcudB1mDd1+9t7DnGk=; h=From:To:Cc:Subject:Date; b=O3dMVzDCrTDe2kJ9DXp6XL1Ps797A/hGgiMdIYJXDsoeDtz6OOkQPyt2CRFis+MjR Gv0QEYK4TKALhfCt1yzauhgrMVekMVlbxZd90DdjoRw/ndWA/XahxOsCB4KeKTdWRM a5zVrMBABimkB+2ZRMRVpqKutdQtJQa8kaXzgqLw= From: Luca Weiss To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: add missing dependency to DRM_PANEL_EDP Date: Sun, 23 Jan 2022 21:43:23 +0100 Message-Id: <20220123204322.345725-1-luca@z3ntu.xyz> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, Luca Weiss , Thierry Reding , ~postmarketos/upstreaming@lists.sr.ht, Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation fails: drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to `drm_panel_dp_aux_backlight' Add a dependency on DRM_KMS_HELPER to fix this. Signed-off-by: Luca Weiss --- I briefly tried "select DRM_KMS_HELPER" but that causes a circular dependency. If someone has a better idea how to solve this, feel free correct me. drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 434c2861bb40..fda97837ecb3 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE config DRM_PANEL_EDP tristate "support for simple Embedded DisplayPort panels" depends on OF + depends on DRM_KMS_HELPER depends on BACKLIGHT_CLASS_DEVICE depends on PM select VIDEOMODE_HELPERS