| Message ID | 20220131165926.3230642-4-lucas.demarchi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Fix header test and log spam on !x86 | expand |
On Mon, 2022-01-31 at 08:59 -0800, Lucas De Marchi wrote: > Following what was done in drm_cache.c, when the stub for > remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip > remap_io_mapping() for non-x86 platforms"), it included a log message > with pr_err(). However just the warning is already enough and switching > to WARN_ONCE() allows us to keep the log message while avoiding log > spam. Reviewed-by: José Roberto de Souza <jose.souza@intel.com> But same suggestion as the first patch in this series about drm_WARN_ONCE(). > > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> > --- > > v3: No changes from previous version, just submitting to the right > mailing list > > drivers/gpu/drm/i915/i915_mm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h > index 3ad22bbe80eb..04c8974d822b 100644 > --- a/drivers/gpu/drm/i915/i915_mm.h > +++ b/drivers/gpu/drm/i915/i915_mm.h > @@ -23,8 +23,7 @@ int remap_io_mapping(struct vm_area_struct *vma, > unsigned long addr, unsigned long pfn, unsigned long size, > struct io_mapping *iomap) > { > - pr_err("Architecture has no %s() and shouldn't be calling this function\n", __func__); > - WARN_ON_ONCE(1); > + WARN_ONCE(1, "Architecture has no drm_cache.c support\n"); > return 0; > } > #endif
diff --git a/drivers/gpu/drm/i915/i915_mm.h b/drivers/gpu/drm/i915/i915_mm.h index 3ad22bbe80eb..04c8974d822b 100644 --- a/drivers/gpu/drm/i915/i915_mm.h +++ b/drivers/gpu/drm/i915/i915_mm.h @@ -23,8 +23,7 @@ int remap_io_mapping(struct vm_area_struct *vma, unsigned long addr, unsigned long pfn, unsigned long size, struct io_mapping *iomap) { - pr_err("Architecture has no %s() and shouldn't be calling this function\n", __func__); - WARN_ON_ONCE(1); + WARN_ONCE(1, "Architecture has no drm_cache.c support\n"); return 0; } #endif
Following what was done in drm_cache.c, when the stub for remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip remap_io_mapping() for non-x86 platforms"), it included a log message with pr_err(). However just the warning is already enough and switching to WARN_ONCE() allows us to keep the log message while avoiding log spam. Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> --- v3: No changes from previous version, just submitting to the right mailing list drivers/gpu/drm/i915/i915_mm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)