| Message ID | 20220207032322.16667-1-akeem.g.abodunrin@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] iommu/core: Remove comment reference to iommu_dev_has_feature | expand |
On 07/02/2022 03:23, Akeem G Abodunrin wrote: > iommu_dev_has_feature() api has been removed by the commit 262948f8ba573 > ("iommu: Delete iommu_dev_has_feature()") - So this patch removes comment > about the api to avoid any confusion. > > Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com> > Cc: Lu Baolu <baolu.lu@linux.intel.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: John Garry <john.garry@huawei.com> BTW, It looks like we can get rid of iommu_ops.dev_has_feat also. It does not seem to be called, while arm-smmu-v3 driver does provide a callback. > --- > include/linux/iommu.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index de0c57a567c8..bea054f2bd4d 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -153,8 +153,7 @@ struct iommu_resv_region { > * supported, this feature must be enabled before and > * disabled after %IOMMU_DEV_FEAT_SVA. > * > - * Device drivers query whether a feature is supported using > - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature(). > + * Device drivers enable the feature via iommu_dev_enable_feature(). > */ > enum iommu_dev_features { > IOMMU_DEV_FEAT_AUX,
diff --git a/include/linux/iommu.h b/include/linux/iommu.h index de0c57a567c8..bea054f2bd4d 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -153,8 +153,7 @@ struct iommu_resv_region { * supported, this feature must be enabled before and * disabled after %IOMMU_DEV_FEAT_SVA. * - * Device drivers query whether a feature is supported using - * iommu_dev_has_feature(), and enable it using iommu_dev_enable_feature(). + * Device drivers enable the feature via iommu_dev_enable_feature(). */ enum iommu_dev_features { IOMMU_DEV_FEAT_AUX,
iommu_dev_has_feature() api has been removed by the commit 262948f8ba573 ("iommu: Delete iommu_dev_has_feature()") - So this patch removes comment about the api to avoid any confusion. Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com> Cc: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Christoph Hellwig <hch@lst.de> --- include/linux/iommu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)