From patchwork Fri Mar 4 00:25:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12768343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0BEDC433F5 for ; Fri, 4 Mar 2022 00:25:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2D8010E3C9; Fri, 4 Mar 2022 00:25:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7D3210E2FD for ; Fri, 4 Mar 2022 00:25:42 +0000 (UTC) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 099FE83BC1; Fri, 4 Mar 2022 01:25:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1646353541; bh=Ynmm1ikdluYKgva2z3zG7aMaPEKfmJI7xp2Q7S3/1rk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IsN+29vQuaVUM/guwCXk0xtp7PcRK0B4bdJQCyjp0j9JUqoRKhA2MYTFpv0XJ5Ngc uWe09t/BC5KVHV/GWQxt2jgZzl6tvvlbDFrjwHZiOj78d8B/CzBF/tVJVSJ/gya2sJ wT1Gat642Nk9PXOGLtx7hhj4gy3myQJPGhVJ8rcqfSVRncVo2PZRuFKgx353bVtEZX 1/gFG7ys07yzToEcXKVAMw8bP0/o9Ne4V1+7hmcVDwfzT+TcfblCE0Cx7kxXJ3tyq0 nnM/g82h6wPkQcxK3VOxCHK++ADcO+sYE3etvqdSHTpps+17e89txIGLCho+viHs36 abDws8l10g3hA== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH V3 07/13] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Date: Fri, 4 Mar 2022 01:25:02 +0100 Message-Id: <20220304002508.75676-8-marex@denx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220304002508.75676-1-marex@denx.de> References: <20220304002508.75676-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Robert Foss , Maxime Ripard , Thomas Zimmermann , Sam Ravnborg , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DSI burst mode is more energy efficient than the DSI sync pulse mode, make use of the burst mode since the chip supports it as well. Disable the generation of EoT packet, the chip ignores it, so no point in emitting it. Enable transmission of data in LP mode, otherwise register read via DSI does not work with this chip. Acked-by: Maxime Ripard Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Thomas Zimmermann To: dri-devel@lists.freedesktop.org --- V2: Rebase on next-20220214 V3: Add AB from Maxime --- drivers/gpu/drm/bridge/chipone-icn6211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 71c83a18984fa..b4e886c2b92a5 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -503,7 +503,8 @@ static int chipone_probe(struct mipi_dsi_device *dsi) dsi->lanes = icn->dsi_lanes; dsi->format = MIPI_DSI_FMT_RGB888; - dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE; + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; ret = mipi_dsi_attach(dsi); if (ret < 0) {