diff mbox series

drm/bridge: anx7625: Fix not correct get property counts

Message ID 20220310091653.1298588-1-xji@analogixsemi.com (mailing list archive)
State New, archived
Headers show
Series drm/bridge: anx7625: Fix not correct get property counts | expand

Commit Message

Xin Ji March 10, 2022, 9:16 a.m. UTC 
The property length which returns from "of_get_property", divided by
sizeof(int) to get the total property counts.

Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")

Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sam Ravnborg March 10, 2022, 6:53 p.m. UTC | #1 
Hi Xin,

On Thu, Mar 10, 2022 at 05:16:53PM +0800, Xin Ji wrote:
> The property length which returns from "of_get_property", divided by
> sizeof(int) to get the total property counts.
> 
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> 
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index c6a9a02ed762..87081d5b408d 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1594,6 +1594,7 @@ static int anx7625_get_swing_setting(struct device *dev,
>  
>  	if (of_get_property(dev->of_node,
>  			    "analogix,lane0-swing", &num_regs)) {
> +		num_regs /= sizeof(int);

Since the property is an array maybe use: of_property_read_u8_array()

	Sam
Xin Ji March 11, 2022, 2:59 a.m. UTC | #2 
On Thu, Mar 10, 2022 at 07:53:59PM +0100, Sam Ravnborg wrote:
> Hi Xin,
> 
> On Thu, Mar 10, 2022 at 05:16:53PM +0800, Xin Ji wrote:
> > The property length which returns from "of_get_property", divided by
> > sizeof(int) to get the total property counts.
> > 
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index c6a9a02ed762..87081d5b408d 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1594,6 +1594,7 @@ static int anx7625_get_swing_setting(struct device *dev,
> >  
> >  	if (of_get_property(dev->of_node,
> >  			    "analogix,lane0-swing", &num_regs)) {
> > +		num_regs /= sizeof(int);
> 
> Since the property is an array maybe use: of_property_read_u8_array()
> 
> 	Sam
Hi Sam, OK, I'll use it to get property data.

Thanks,
Xin
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index c6a9a02ed762..87081d5b408d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1594,6 +1594,7 @@  static int anx7625_get_swing_setting(struct device *dev,
 
 	if (of_get_property(dev->of_node,
 			    "analogix,lane0-swing", &num_regs)) {
+		num_regs /= sizeof(int);
 		if (num_regs > DP_TX_SWING_REG_CNT)
 			num_regs = DP_TX_SWING_REG_CNT;
 
@@ -1604,6 +1605,7 @@  static int anx7625_get_swing_setting(struct device *dev,
 
 	if (of_get_property(dev->of_node,
 			    "analogix,lane1-swing", &num_regs)) {
+		num_regs /= sizeof(int);
 		if (num_regs > DP_TX_SWING_REG_CNT)
 			num_regs = DP_TX_SWING_REG_CNT;