| Message ID | 20220322131742.11566-7-patrik.r.jakobsson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] drm/gma500: Use managed drmm_mode_config_init() | expand |
Hi Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: > These functions operate on a crtc and should be prefixed properly. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> For the whole patchset: Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> If you like, please consider the few comments I had. Best regards Thomas > --- > drivers/gpu/drm/gma500/gma_display.c | 6 +++--- > drivers/gpu/drm/gma500/psb_irq.c | 6 +++--- > drivers/gpu/drm/gma500/psb_irq.h | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c > index 369bc1f751cb..34ec3fca09ba 100644 > --- a/drivers/gpu/drm/gma500/gma_display.c > +++ b/drivers/gpu/drm/gma500/gma_display.c > @@ -575,9 +575,9 @@ const struct drm_crtc_funcs gma_crtc_funcs = { > .set_config = gma_crtc_set_config, > .destroy = gma_crtc_destroy, > .page_flip = gma_crtc_page_flip, > - .enable_vblank = gma_enable_vblank, > - .disable_vblank = gma_disable_vblank, > - .get_vblank_counter = gma_get_vblank_counter, > + .enable_vblank = gma_crtc_enable_vblank, > + .disable_vblank = gma_crtc_disable_vblank, > + .get_vblank_counter = gma_crtc_get_vblank_counter, > }; > > /* > diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c > index 2e8ded532930..e6e6d61bbeab 100644 > --- a/drivers/gpu/drm/gma500/psb_irq.c > +++ b/drivers/gpu/drm/gma500/psb_irq.c > @@ -371,7 +371,7 @@ void gma_irq_uninstall(struct drm_device *dev) > free_irq(pdev->irq, dev); > } > > -int gma_enable_vblank(struct drm_crtc *crtc) > +int gma_crtc_enable_vblank(struct drm_crtc *crtc) > { > struct drm_device *dev = crtc->dev; > unsigned int pipe = crtc->index; > @@ -404,7 +404,7 @@ int gma_enable_vblank(struct drm_crtc *crtc) > return 0; > } > > -void gma_disable_vblank(struct drm_crtc *crtc) > +void gma_crtc_disable_vblank(struct drm_crtc *crtc) > { > struct drm_device *dev = crtc->dev; > unsigned int pipe = crtc->index; > @@ -428,7 +428,7 @@ void gma_disable_vblank(struct drm_crtc *crtc) > /* Called from drm generic code, passed a 'crtc', which > * we use as a pipe index > */ > -u32 gma_get_vblank_counter(struct drm_crtc *crtc) > +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc) > { > struct drm_device *dev = crtc->dev; > unsigned int pipe = crtc->index; > diff --git a/drivers/gpu/drm/gma500/psb_irq.h b/drivers/gpu/drm/gma500/psb_irq.h > index c22878914f5b..b51e395194ff 100644 > --- a/drivers/gpu/drm/gma500/psb_irq.h > +++ b/drivers/gpu/drm/gma500/psb_irq.h > @@ -20,9 +20,9 @@ void gma_irq_postinstall(struct drm_device *dev); > int gma_irq_install(struct drm_device *dev, unsigned int irq); > void gma_irq_uninstall(struct drm_device *dev); > > -int gma_enable_vblank(struct drm_crtc *crtc); > -void gma_disable_vblank(struct drm_crtc *crtc); > -u32 gma_get_vblank_counter(struct drm_crtc *crtc); > +int gma_crtc_enable_vblank(struct drm_crtc *crtc); > +void gma_crtc_disable_vblank(struct drm_crtc *crtc); > +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc); > void gma_enable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask); > void gma_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask); >
On Tue, Mar 22, 2022 at 8:36 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > Hi > > Am 22.03.22 um 14:17 schrieb Patrik Jakobsson: > > These functions operate on a crtc and should be prefixed properly. > > > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > For the whole patchset: > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > If you like, please consider the few comments I had. Thanks for the review. > > Best regards > Thomas > > > > --- > > drivers/gpu/drm/gma500/gma_display.c | 6 +++--- > > drivers/gpu/drm/gma500/psb_irq.c | 6 +++--- > > drivers/gpu/drm/gma500/psb_irq.h | 6 +++--- > > 3 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c > > index 369bc1f751cb..34ec3fca09ba 100644 > > --- a/drivers/gpu/drm/gma500/gma_display.c > > +++ b/drivers/gpu/drm/gma500/gma_display.c > > @@ -575,9 +575,9 @@ const struct drm_crtc_funcs gma_crtc_funcs = { > > .set_config = gma_crtc_set_config, > > .destroy = gma_crtc_destroy, > > .page_flip = gma_crtc_page_flip, > > - .enable_vblank = gma_enable_vblank, > > - .disable_vblank = gma_disable_vblank, > > - .get_vblank_counter = gma_get_vblank_counter, > > + .enable_vblank = gma_crtc_enable_vblank, > > + .disable_vblank = gma_crtc_disable_vblank, > > + .get_vblank_counter = gma_crtc_get_vblank_counter, > > }; > > > > /* > > diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c > > index 2e8ded532930..e6e6d61bbeab 100644 > > --- a/drivers/gpu/drm/gma500/psb_irq.c > > +++ b/drivers/gpu/drm/gma500/psb_irq.c > > @@ -371,7 +371,7 @@ void gma_irq_uninstall(struct drm_device *dev) > > free_irq(pdev->irq, dev); > > } > > > > -int gma_enable_vblank(struct drm_crtc *crtc) > > +int gma_crtc_enable_vblank(struct drm_crtc *crtc) > > { > > struct drm_device *dev = crtc->dev; > > unsigned int pipe = crtc->index; > > @@ -404,7 +404,7 @@ int gma_enable_vblank(struct drm_crtc *crtc) > > return 0; > > } > > > > -void gma_disable_vblank(struct drm_crtc *crtc) > > +void gma_crtc_disable_vblank(struct drm_crtc *crtc) > > { > > struct drm_device *dev = crtc->dev; > > unsigned int pipe = crtc->index; > > @@ -428,7 +428,7 @@ void gma_disable_vblank(struct drm_crtc *crtc) > > /* Called from drm generic code, passed a 'crtc', which > > * we use as a pipe index > > */ > > -u32 gma_get_vblank_counter(struct drm_crtc *crtc) > > +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc) > > { > > struct drm_device *dev = crtc->dev; > > unsigned int pipe = crtc->index; > > diff --git a/drivers/gpu/drm/gma500/psb_irq.h b/drivers/gpu/drm/gma500/psb_irq.h > > index c22878914f5b..b51e395194ff 100644 > > --- a/drivers/gpu/drm/gma500/psb_irq.h > > +++ b/drivers/gpu/drm/gma500/psb_irq.h > > @@ -20,9 +20,9 @@ void gma_irq_postinstall(struct drm_device *dev); > > int gma_irq_install(struct drm_device *dev, unsigned int irq); > > void gma_irq_uninstall(struct drm_device *dev); > > > > -int gma_enable_vblank(struct drm_crtc *crtc); > > -void gma_disable_vblank(struct drm_crtc *crtc); > > -u32 gma_get_vblank_counter(struct drm_crtc *crtc); > > +int gma_crtc_enable_vblank(struct drm_crtc *crtc); > > +void gma_crtc_disable_vblank(struct drm_crtc *crtc); > > +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc); > > void gma_enable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask); > > void gma_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask); > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Ivo Totev
diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index 369bc1f751cb..34ec3fca09ba 100644 --- a/drivers/gpu/drm/gma500/gma_display.c +++ b/drivers/gpu/drm/gma500/gma_display.c @@ -575,9 +575,9 @@ const struct drm_crtc_funcs gma_crtc_funcs = { .set_config = gma_crtc_set_config, .destroy = gma_crtc_destroy, .page_flip = gma_crtc_page_flip, - .enable_vblank = gma_enable_vblank, - .disable_vblank = gma_disable_vblank, - .get_vblank_counter = gma_get_vblank_counter, + .enable_vblank = gma_crtc_enable_vblank, + .disable_vblank = gma_crtc_disable_vblank, + .get_vblank_counter = gma_crtc_get_vblank_counter, }; /* diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c index 2e8ded532930..e6e6d61bbeab 100644 --- a/drivers/gpu/drm/gma500/psb_irq.c +++ b/drivers/gpu/drm/gma500/psb_irq.c @@ -371,7 +371,7 @@ void gma_irq_uninstall(struct drm_device *dev) free_irq(pdev->irq, dev); } -int gma_enable_vblank(struct drm_crtc *crtc) +int gma_crtc_enable_vblank(struct drm_crtc *crtc) { struct drm_device *dev = crtc->dev; unsigned int pipe = crtc->index; @@ -404,7 +404,7 @@ int gma_enable_vblank(struct drm_crtc *crtc) return 0; } -void gma_disable_vblank(struct drm_crtc *crtc) +void gma_crtc_disable_vblank(struct drm_crtc *crtc) { struct drm_device *dev = crtc->dev; unsigned int pipe = crtc->index; @@ -428,7 +428,7 @@ void gma_disable_vblank(struct drm_crtc *crtc) /* Called from drm generic code, passed a 'crtc', which * we use as a pipe index */ -u32 gma_get_vblank_counter(struct drm_crtc *crtc) +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc) { struct drm_device *dev = crtc->dev; unsigned int pipe = crtc->index; diff --git a/drivers/gpu/drm/gma500/psb_irq.h b/drivers/gpu/drm/gma500/psb_irq.h index c22878914f5b..b51e395194ff 100644 --- a/drivers/gpu/drm/gma500/psb_irq.h +++ b/drivers/gpu/drm/gma500/psb_irq.h @@ -20,9 +20,9 @@ void gma_irq_postinstall(struct drm_device *dev); int gma_irq_install(struct drm_device *dev, unsigned int irq); void gma_irq_uninstall(struct drm_device *dev); -int gma_enable_vblank(struct drm_crtc *crtc); -void gma_disable_vblank(struct drm_crtc *crtc); -u32 gma_get_vblank_counter(struct drm_crtc *crtc); +int gma_crtc_enable_vblank(struct drm_crtc *crtc); +void gma_crtc_disable_vblank(struct drm_crtc *crtc); +u32 gma_crtc_get_vblank_counter(struct drm_crtc *crtc); void gma_enable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask); void gma_disable_pipestat(struct drm_psb_private *dev_priv, int pipe, u32 mask);
These functions operate on a crtc and should be prefixed properly. Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> --- drivers/gpu/drm/gma500/gma_display.c | 6 +++--- drivers/gpu/drm/gma500/psb_irq.c | 6 +++--- drivers/gpu/drm/gma500/psb_irq.h | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-)