| Message ID | 20220406172956.3953-3-wens@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | drm/ssd130x: Add support for SINO WEALTH SH1106 | expand |
Hi Chen-Yu, On Wed, Apr 6, 2022 at 10:13 PM Chen-Yu Tsai <wens@kernel.org> wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > compatible with the SSD1306. It supports a slightly wider display, > at 132 instead of 128 pixels. The basic commands are the same, but > the SH1106 doesn't support the horizontal or vertical address modes. > > Add a compatible string for it. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > @@ -13,6 +13,7 @@ maintainers: > properties: > compatible: > enum: > + - sinowealth,sh1106-i2c Please don't introduce new compatible values including the bus type. There is no need for that, and this will only lead to more deprecated compatible values soon... Oops, this is already commit 97a40c23cda5d64a ("dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106") in drm-misc/for-linux-next... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, On 4/11/22 15:35, Geert Uytterhoeven wrote: > Hi Chen-Yu, [snip] >> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> @@ -13,6 +13,7 @@ maintainers: >> properties: >> compatible: >> enum: >> + - sinowealth,sh1106-i2c > > Please don't introduce new compatible values including the bus type. > There is no need for that, and this will only lead to more deprecated > compatible values soon... > > Oops, this is already commit 97a40c23cda5d64a ("dt-bindings: > display: ssd1307fb: Add entry for SINO WEALTH SH1106") in > drm-misc/for-linux-next... > Yeah, too late :/ I didn't think it would be controversial at the time.
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index 9baafd0c42dd..ade61d502edd 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -13,6 +13,7 @@ maintainers: properties: compatible: enum: + - sinowealth,sh1106-i2c - solomon,ssd1305fb-i2c - solomon,ssd1306fb-i2c - solomon,ssd1307fb-i2c @@ -131,6 +132,18 @@ required: - reg allOf: + - if: + properties: + compatible: + contains: + const: sinowealth,sh1106-i2c + then: + properties: + solomon,dclk-div: + default: 1 + solomon,dclk-frq: + default: 5 + - if: properties: compatible: