| Message ID | 20220421133028.724954-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/gsp: change gv100_gsp from global to static | expand |
Reviewed-by: Lyude Paul <lyude@redhat.com> Will push upstream in a moment On Thu, 2022-04-21 at 09:30 -0400, Tom Rix wrote: > Smatch reports this issue > gv100.c:46:1: warning: symbol 'gv100_gsp' was not declared. Should it be > static? > > gv100_gsp is only used in gv100.c so change its > storage-class specifier to static. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > index 2ac7fc934c09..6c4ef62a746a 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c > @@ -42,7 +42,7 @@ gv100_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct > nvkm_gsp_fwif *fwif) > return 0; > } > > -struct nvkm_gsp_fwif > +static struct nvkm_gsp_fwif > gv100_gsp[] = { > { -1, gv100_gsp_nofw, &gv100_gsp_flcn }, > {}
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c index 2ac7fc934c09..6c4ef62a746a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c @@ -42,7 +42,7 @@ gv100_gsp_nofw(struct nvkm_gsp *gsp, int ver, const struct nvkm_gsp_fwif *fwif) return 0; } -struct nvkm_gsp_fwif +static struct nvkm_gsp_fwif gv100_gsp[] = { { -1, gv100_gsp_nofw, &gv100_gsp_flcn }, {}
Smatch reports this issue gv100.c:46:1: warning: symbol 'gv100_gsp' was not declared. Should it be static? gv100_gsp is only used in gv100.c so change its storage-class specifier to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/gv100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)