diff mbox series

[2/3] drm/bridge: tc358767: Report DSI-to-(e)DP as supported

Message ID 20220518233602.248185-2-marex@denx.de (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/bridge: tc358767: Handle dsi_lanes == 0 as invalid | expand

Commit Message

Marek Vasut May 18, 2022, 11:36 p.m. UTC
The DSI-to-e(DP) mode is now supported, update the driver comment
to reflect this. No functional change.

Fixes: 3080c21a043ab ("drm/bridge: tc358767: Add DSI-to-(e)DP mode support")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/bridge/tc358767.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrzej Hajda May 19, 2022, 7:46 a.m. UTC | #1
On 19.05.2022 01:36, Marek Vasut wrote:
> The DSI-to-e(DP) mode is now supported, update the driver comment
> to reflect this. No functional change.
> 
> Fixes: 3080c21a043ab ("drm/bridge: tc358767: Add DSI-to-(e)DP mode support")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>   drivers/gpu/drm/bridge/tc358767.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 84e6b5aa8dd1f..a8bb6de9e600a 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -6,7 +6,7 @@
>    * The following modes are supported:
>    *   DPI->(e)DP -- supported
>    *   DSI->DPI .... supported
> - *   DSI->(e)DP .. NOT supported
> + *   DSI->(e)DP .. supported

Since everything is supported(?) this message becomes useless, or can be 
shortened. With or w/o:

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej

>    *
>    * Copyright (C) 2016 CogentEmbedded Inc
>    * Author: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Lucas Stach May 19, 2022, 7:52 a.m. UTC | #2
Am Donnerstag, dem 19.05.2022 um 01:36 +0200 schrieb Marek Vasut:
> The DSI-to-e(DP) mode is now supported, update the driver comment
> to reflect this. No functional change.
> 
> Fixes: 3080c21a043ab ("drm/bridge: tc358767: Add DSI-to-(e)DP mode support")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/bridge/tc358767.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 84e6b5aa8dd1f..a8bb6de9e600a 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -6,7 +6,7 @@
>   * The following modes are supported:
>   *   DPI->(e)DP -- supported
>   *   DSI->DPI .... supported
> - *   DSI->(e)DP .. NOT supported
> + *   DSI->(e)DP .. supported

Couldn't we just drop the status behind the modes when the line above
already states that those modes are supported, which is now true for
all of them? But I then also don't care too much about it, so if you
like your version better, feel free to commit with:

Reviewed-by: Lucas Stach <l.stach@pengutronix.de> 

>   *
>   * Copyright (C) 2016 CogentEmbedded Inc
>   * Author: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 84e6b5aa8dd1f..a8bb6de9e600a 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -6,7 +6,7 @@ 
  * The following modes are supported:
  *   DPI->(e)DP -- supported
  *   DSI->DPI .... supported
- *   DSI->(e)DP .. NOT supported
+ *   DSI->(e)DP .. supported
  *
  * Copyright (C) 2016 CogentEmbedded Inc
  * Author: Andrey Gusakov <andrey.gusakov@cogentembedded.com>