From patchwork Thu Jun 9 22:34:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 12876075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5874CC43334 for ; Thu, 9 Jun 2022 22:34:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6615D12B94B; Thu, 9 Jun 2022 22:34:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D066A12B94B for ; Thu, 9 Jun 2022 22:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654814083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4JBJAbQAGlq6duKRB7SY6Yx4CLSxDIaBCygjW0wpUqc=; b=YA+gtBX9+u2nIRywjzGY5/yaDyXW2dfBChGZSDFg0yB8+1CI99KzjkRxeb7xe06zndtrZa E12qdff4OQE8vlpIAjrv7KU7qu+DSXHpfLtZuHwYvJvbP/Fe0wslYFHSIJGtdQbD3EZbBp 3f7nreh+G4Pky4MoI3ptlLizOYS37n8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-i7-SaOyCOcSKVOEFxQu2uA-1; Thu, 09 Jun 2022 18:34:42 -0400 X-MC-Unique: i7-SaOyCOcSKVOEFxQu2uA-1 Received: by mail-wm1-f69.google.com with SMTP id ay1-20020a05600c1e0100b0039c3a3fc6a4so337306wmb.4 for ; Thu, 09 Jun 2022 15:34:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4JBJAbQAGlq6duKRB7SY6Yx4CLSxDIaBCygjW0wpUqc=; b=JSpw+vi60/3h5ml9Z2D7hqTAPuHVRhGXG/aCECSfRczdBhNmWyGcDJITKcXBtjPICt ZABc6S3c+6ODIiHJdgBuPNYa3pCh8T5lggxESflTKho6RkqjmhQB7n3x1vhvIk/t/jrg WM/G2lZ5I7r7koEXbNcDulEVIN5OxTlib+r5PvwFF+4OYh85QcXq15W1Ha4rwWjqv62k /cugPxmSpHGJD9wPtOd37HEinJP10zcvlbGhJUuBqmKi9TwzC+7zt4342KVxpAn1diHH rfDwAMtorO5kQukzTZwcc64yIq6VhSnWQ6f/9+fzd5Z/AaUGALQm8oKKqVkK9CxDv/c/ wZFw== X-Gm-Message-State: AOAM531aEfvcuZd8N+vj6wlFPXtylH+v7w5myoe+ArcRJ9cZvk5OdnG9 yjjAQa8TrhUW98L2qJZLb4BtB6qtN0kDw90bqKmAmhYHT4d5Q/QBiPV9lOS43UOBmZDwD/XshI/ cgVDLSiCbJ36U98+/OXZ803rMdsVz X-Received: by 2002:adf:d4c7:0:b0:213:ba6b:b017 with SMTP id w7-20020adfd4c7000000b00213ba6bb017mr37035308wrk.652.1654814081432; Thu, 09 Jun 2022 15:34:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBiSUPEKkjirE2HkOG+I6xW8jverC00Ir2fvZGqGugiHwBbX2BUOYVgy8sHotRHakXFdIqqw== X-Received: by 2002:adf:d4c7:0:b0:213:ba6b:b017 with SMTP id w7-20020adfd4c7000000b00213ba6bb017mr37035279wrk.652.1654814081091; Thu, 09 Jun 2022 15:34:41 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id b18-20020adfde12000000b0020d0f111241sm25706675wrm.24.2022.06.09.15.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 15:34:40 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH] staging: olpc_dcon: mark driver as broken Date: Fri, 10 Jun 2022 00:34:24 +0200 Message-Id: <20220609223424.907174-1-javierm@redhat.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jerry Lin , Jens Frederich , Daniel Vetter , Helge Deller , linux-staging@lists.linux.dev, Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Geert Uytterhoeven , Thomas Zimmermann , Greg Kroah-Hartman , Sam Ravnborg , Jon Nettleton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The commit eecb3e4e5d9d ("staging: olpc_dcon: add OLPC display controller (DCON) support") added this driver in 2010, and has been in staging since then. It was marked as broken at some point because it didn't even build but that got removed once the build issues were addressed. But it seems that the work to move this driver out of staging has stalled, the last non-trivial change to fix one of the items mentioned in its todo file was commit e40219d5e4b2 ("staging: olpc_dcon: allow simultaneous XO-1 and XO-1.5 support") in 2019. And even if work to destage the driver is resumed, the fbdev subsystem has been deprecated for a long time and instead it should be ported to DRM. Now this driver is preventing to land a kernel wide change, that makes the num_registered_fb symbol to be private to the fbmem.c file. So let's just mark the driver as broken. Someone can then work on making it not depend on the num_registered_fb symbol, allowing to drop the broken dependency again. Suggested-by: Sam Ravnborg Signed-off-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann --- drivers/staging/olpc_dcon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig index d1a0dea09ef0..d0ba34cc32f7 100644 --- a/drivers/staging/olpc_dcon/Kconfig +++ b/drivers/staging/olpc_dcon/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 config FB_OLPC_DCON tristate "One Laptop Per Child Display CONtroller support" - depends on OLPC && FB + depends on OLPC && FB && BROKEN depends on I2C depends on GPIO_CS5535 && ACPI select BACKLIGHT_CLASS_DEVICE