From patchwork Thu Jun 30 19:51:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 12902117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78D30C43334 for ; Thu, 30 Jun 2022 19:51:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 532FE12AED5; Thu, 30 Jun 2022 19:51:25 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7533212AEDB; Thu, 30 Jun 2022 19:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656618681; x=1688154681; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IOsqNAPdvxxmapBj6P4re73SuHAYHc+8ZAPR3O4fu8Q=; b=Hw6GrUcVMepAlLJQXPA1DLmFBPlJxhgoyf/qxpBCEe1/9eXFAbWVULui bv2yPLlUDVvs4R4GcZ2WXPRF5dhCqRY8vS1utfW5miskyxPTpN3hPg8yB 6L95pgBVTlzXr+eox9xVvd5fO3L58AueIArRqrbaIc/dVmTvsw06t/JaT kInnwrLYv5eflOXzxvBwAXjqAj11x6z41g9Ok9ar7FMDW87+JGvarDb4G TzaNR3j+0r4BluK9FnGhBK0FzZViPAXgeiG/D2Y//cLE+wxpUbNTqP1Xb RQhhinp41rIKfstsJPld7RxnODO5wqFEGK/SrPswO3dIwrRdOiT29MZq1 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="262251818" X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="262251818" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 12:51:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,235,1650956400"; d="scan'208";a="681110587" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.161]) by FMSMGA003.fm.intel.com with SMTP; 30 Jun 2022 12:51:18 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 30 Jun 2022 22:51:17 +0300 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 1/4] drm/vmwgfx: Stop using 'TRUE' Date: Thu, 30 Jun 2022 22:51:11 +0300 Message-Id: <20220630195114.17407-2-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220630195114.17407-1-ville.syrjala@linux.intel.com> References: <20220630195114.17407-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Sam Ravnborg , intel-gfx@lists.freedesktop.org, VMware Graphics Reviewers Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Ville Syrjälä Stop using the 'TRUE' define. This ultimately gets defined by acpi/actypes.h that gets included here via a convoluted chain of other headers. drm_crtc.h is part of that chain, and I'm trying to eliminate all unnecessary includes from it to avoid pointless rebuilds. v2: Split out from the bigger patch Cc: Zack Rusin Cc: VMware Graphics Reviewers Acked-by: Sam Ravnborg Acked-by: Jani Nikula Signed-off-by: Ville Syrjälä Acked-by: Sam Ravnborg > Acked-by: Jani Nikula > Signed-off-by: Ville Syrjälä > Reviewed-by: Zack Rusin > --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 693028c31b6b..ff2f735bbe7a 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -252,7 +252,7 @@ static void vmw_cursor_update_position(struct vmw_private *dev_priv, vmw_write(dev_priv, SVGA_REG_CURSOR4_Y, y); vmw_write(dev_priv, SVGA_REG_CURSOR4_SCREEN_ID, SVGA3D_INVALID_ID); vmw_write(dev_priv, SVGA_REG_CURSOR4_ON, svga_cursor_on); - vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, TRUE); + vmw_write(dev_priv, SVGA_REG_CURSOR4_SUBMIT, 1); } else if (vmw_is_cursor_bypass3_enabled(dev_priv)) { vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_ON, svga_cursor_on); vmw_fifo_mem_write(dev_priv, SVGA_FIFO_CURSOR_X, x);