From patchwork Sat Jul 9 17:36:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12912294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64136C433EF for ; Sat, 9 Jul 2022 17:36:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC0AE11A075; Sat, 9 Jul 2022 17:36:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DA32113FFC for ; Sat, 9 Jul 2022 17:36:25 +0000 (UTC) Received: from tr.lan (ip-86-49-12-201.bb.vodafone.cz [86.49.12.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3A660845E3; Sat, 9 Jul 2022 19:36:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1657388183; bh=ejhlCQfiKtKRvIn6WGQWt+nRi+8ptnpW/1C7jajPIT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oEqC0Qo9KWR1DpFgXtw8y9Ajw3cYa18fNth62NfxdSy+fJbH6l2gDBFO5tChTyuFd aTWQDsDe9FdHqdao09A7R6NxIzOfFCnkqm2QlxyhoYGOXqPsmRv1VjYW5haW7OAGoB 4IYuuSSl4C4ZOdhZmq5gW6Njmb/i+R6jki6TVxa6C0YyRR+3g7DchsRqfhhoisvHbY cusmipS+zvst9I1ASUEFAcf0aJCZ8wqKGxeQ/NAGS0busLub81F6tHTLy6RAECBmvI p6ZK3UHSxFaUZWy4J2Bib06LMmnBAt80HBzOwmwsrsBkLhRehFZAMER4s2+WZcQgPO 0tabi6ONjy+HQ== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v4 4/4] drm/lcdif: switch to devm_drm_of_get_bridge Date: Sat, 9 Jul 2022 19:36:06 +0200 Message-Id: <20220709173606.72852-4-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220709173606.72852-1-marex@denx.de> References: <20220709173606.72852-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Alexander Stein , Peng Fan , Liu Ying , robert.foss@linaro.org, Liu Ying , Martyn Welch , Laurent Pinchart , Robby Cai , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Acked-by: Sam Ravnborg Reviewed-by: Liu Ying Reported-by: Liu Ying Tested-by: Martyn Welch Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off-by: Marek Vasut Cc: Alexander Stein Cc: Laurent Pinchart Cc: Liu Ying Cc: Lucas Stach Cc: Marek Vasut Cc: Martyn Welch Cc: Peng Fan Cc: Robby Cai Cc: Sam Ravnborg Cc: Stefan Agner --- V2: Add RB from Liu V3: Add TB from Martyn from V1 V4: Add AB from Sam from V2 --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c index 1370889c6d687..746a4261f3da2 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -42,23 +42,11 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) { struct drm_device *drm = lcdif->drm; struct drm_bridge *bridge; - struct drm_panel *panel; int ret; - ret = drm_of_find_panel_or_bridge(drm->dev->of_node, 0, 0, &panel, - &bridge); - if (ret) - return ret; - - if (panel) { - bridge = devm_drm_panel_bridge_add_typed(drm->dev, panel, - DRM_MODE_CONNECTOR_DPI); - if (IS_ERR(bridge)) - return PTR_ERR(bridge); - } - - if (!bridge) - return -ENODEV; + bridge = devm_drm_of_get_bridge(drm->dev, drm->dev->of_node, 0, 0); + if (IS_ERR(bridge)) + return PTR_ERR(bridge); ret = drm_bridge_attach(&lcdif->encoder, bridge, NULL, 0); if (ret)