| Message ID | 20220721020552.1397598-1-apopple@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/gup.c: Fix formating in check_and_migrate_movable_page() | expand |
On 21.07.22 04:05, Alistair Popple wrote: > Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning > instead of failing") added a badly formatted if statement. Fix it. > > Signed-off-by: Alistair Popple <apopple@nvidia.com> > Reported-by: David Hildenbrand <david@redhat.com> > --- > > Apologies Andrew for missing this. Hopefully this fixes things. > > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 364b274a10c2..c6d060dee9e0 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, > folio_nr_pages(folio)); > } > > - if (!list_empty(&movable_page_list) || isolation_error_count > - || coherent_pages) > + if (!list_empty(&movable_page_list) || isolation_error_count || > + coherent_pages) > goto unpin_pages; > > /* Happy to see the series go upstream soon. Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/gup.c b/mm/gup.c index 364b274a10c2..c6d060dee9e0 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, folio_nr_pages(folio)); } - if (!list_empty(&movable_page_list) || isolation_error_count - || coherent_pages) + if (!list_empty(&movable_page_list) || isolation_error_count || + coherent_pages) goto unpin_pages; /*
Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning instead of failing") added a badly formatted if statement. Fix it. Signed-off-by: Alistair Popple <apopple@nvidia.com> Reported-by: David Hildenbrand <david@redhat.com> --- Apologies Andrew for missing this. Hopefully this fixes things. mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)