| Message ID | 20220819140852.255187-3-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/4] drm/lcdif: Clean up headers | expand |
Hello Marek, Am Freitag, 19. August 2022, 16:08:51 CEST schrieb Marek Vasut: > Update debug print to report bridge timings over connector ones. > Drop missed comment commit from mxsfb. > > Acked-by: Sam Ravnborg <sam@ravnborg.org> > Reviewed-by: Liu Ying <victor.liu@nxp.com> > Reported-by: Liu Ying <victor.liu@oss.nxp.com> > Tested-by: Martyn Welch <martyn.welch@collabora.com> > Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Alexander Stein <alexander.stein@ew.tq-group.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Liu Ying <victor.liu@nxp.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Martyn Welch <martyn.welch@collabora.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Robby Cai <robby.cai@nxp.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Stefan Agner <stefan@agner.ch> > --- > V2: Add RB from Liu > V3: Add TB from Martyn from V1 > V4: Add AB from Sam from V2 > V5: Rebase on current drm-misc-next > --- > drivers/gpu/drm/mxsfb/lcdif_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > b/drivers/gpu/drm/mxsfb/lcdif_kms.c index db7a90e5497c6..b1092aab14231 > 100644 > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c > +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c > @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct > lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: > %dkHz (actual: %dkHz)\n", m->crtc_clock, > (int)(clk_get_rate(lcdif->clk) / 1000)); > - DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n", > + DRM_DEV_DEBUG_DRIVER(drm->dev, "Bridge bus_flags: 0x%08X\n", > bus_flags); > DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags); Is there any benefit to explicitly state it is the bridge input flags? Anyway: Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
On 8/22/22 08:24, Alexander Stein wrote: Hi, [...] >> --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c >> +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c >> @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct >> lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: >> %dkHz (actual: %dkHz)\n", m->crtc_clock, >> (int)(clk_get_rate(lcdif->clk) / 1000)); >> - DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n", >> + DRM_DEV_DEBUG_DRIVER(drm->dev, "Bridge bus_flags: 0x%08X\n", >> bus_flags); >> DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags); > > Is there any benefit to explicitly state it is the bridge input flags? I don't think so, since it cannot be any other flags (you cannot link bridge output to crtc output for example). [...]
diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index db7a90e5497c6..b1092aab14231 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n", m->crtc_clock, (int)(clk_get_rate(lcdif->clk) / 1000)); - DRM_DEV_DEBUG_DRIVER(drm->dev, "Connector bus_flags: 0x%08X\n", + DRM_DEV_DEBUG_DRIVER(drm->dev, "Bridge bus_flags: 0x%08X\n", bus_flags); DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags);