| Message ID | 20220823145649.3118479-12-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: display: adi, adv75xx: Add missing graph schema references | expand |
On 23/08/2022 17:56, Rob Herring wrote: > DT bindings using the graph binding must have references to the graph > binding schema. These are missing from the adi,adv7511 and adi,adv7533 > bindings, so add them. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Rob, Thank you for the patch. On Tue, Aug 23, 2022 at 09:56:43AM -0500, Rob Herring wrote: > DT bindings using the graph binding must have references to the graph > binding schema. These are missing from the adi,adv7511 and adi,adv7533 > bindings, so add them. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../bindings/display/bridge/adi,adv7511.yaml | 14 ++++++-------- > .../bindings/display/bridge/adi,adv7533.yaml | 14 ++++++-------- > 2 files changed, 12 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml > index f08a01dfedf3..5bbe81862c8f 100644 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml > @@ -117,23 +117,21 @@ properties: > > ports: > description: > - The ADV7511(W)/13 has two video ports and one audio port. This node > - models their connections as documented in > - Documentation/devicetree/bindings/media/video-interfaces.txt > - Documentation/devicetree/bindings/graph.txt > - type: object > + The ADV7511(W)/13 has two video ports and one audio port. > + $ref: /schemas/graph.yaml#/properties/ports > + > properties: > port@0: > description: Video port for the RGB or YUV input. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > port@1: > description: Video port for the HDMI output. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > port@2: > description: Audio port for the HDMI output. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > # adi,input-colorspace and adi,input-clock are required except in > # "rgb 1x" and "yuv444 1x" modes, in which case they must not be > diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > index f36209137c8a..987aa83c2649 100644 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml > @@ -91,25 +91,23 @@ properties: > > ports: > description: > - The ADV7533/35 has two video ports and one audio port. This node > - models their connections as documented in > - Documentation/devicetree/bindings/media/video-interfaces.txt > - Documentation/devicetree/bindings/graph.txt > - type: object > + The ADV7533/35 has two video ports and one audio port. > + $ref: /schemas/graph.yaml#/properties/ports > + > properties: > port@0: > description: > Video port for the DSI input. The remote endpoint phandle > should be a reference to a valid mipi_dsi_host_device. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > port@1: > description: Video port for the HDMI output. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > port@2: > description: Audio port for the HDMI output. > - type: object > + $ref: /schemas/graph.yaml#/properties/port > > required: > - compatible
On Tue, 23 Aug 2022 09:56:43 -0500, Rob Herring wrote: > DT bindings using the graph binding must have references to the graph > binding schema. These are missing from the adi,adv7511 and adi,adv7533 > bindings, so add them. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/display/bridge/adi,adv7511.yaml | 14 ++++++-------- > .../bindings/display/bridge/adi,adv7533.yaml | 14 ++++++-------- > 2 files changed, 12 insertions(+), 16 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml index f08a01dfedf3..5bbe81862c8f 100644 --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.yaml @@ -117,23 +117,21 @@ properties: ports: description: - The ADV7511(W)/13 has two video ports and one audio port. This node - models their connections as documented in - Documentation/devicetree/bindings/media/video-interfaces.txt - Documentation/devicetree/bindings/graph.txt - type: object + The ADV7511(W)/13 has two video ports and one audio port. + $ref: /schemas/graph.yaml#/properties/ports + properties: port@0: description: Video port for the RGB or YUV input. - type: object + $ref: /schemas/graph.yaml#/properties/port port@1: description: Video port for the HDMI output. - type: object + $ref: /schemas/graph.yaml#/properties/port port@2: description: Audio port for the HDMI output. - type: object + $ref: /schemas/graph.yaml#/properties/port # adi,input-colorspace and adi,input-clock are required except in # "rgb 1x" and "yuv444 1x" modes, in which case they must not be diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml index f36209137c8a..987aa83c2649 100644 --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml @@ -91,25 +91,23 @@ properties: ports: description: - The ADV7533/35 has two video ports and one audio port. This node - models their connections as documented in - Documentation/devicetree/bindings/media/video-interfaces.txt - Documentation/devicetree/bindings/graph.txt - type: object + The ADV7533/35 has two video ports and one audio port. + $ref: /schemas/graph.yaml#/properties/ports + properties: port@0: description: Video port for the DSI input. The remote endpoint phandle should be a reference to a valid mipi_dsi_host_device. - type: object + $ref: /schemas/graph.yaml#/properties/port port@1: description: Video port for the HDMI output. - type: object + $ref: /schemas/graph.yaml#/properties/port port@2: description: Audio port for the HDMI output. - type: object + $ref: /schemas/graph.yaml#/properties/port required: - compatible
DT bindings using the graph binding must have references to the graph binding schema. These are missing from the adi,adv7511 and adi,adv7533 bindings, so add them. Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/display/bridge/adi,adv7511.yaml | 14 ++++++-------- .../bindings/display/bridge/adi,adv7533.yaml | 14 ++++++-------- 2 files changed, 12 insertions(+), 16 deletions(-)