From patchwork Mon Aug 29 15:15:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 12958022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA6BBECAAD5 for ; Mon, 29 Aug 2022 15:15:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D694710F392; Mon, 29 Aug 2022 15:15:26 +0000 (UTC) Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB7D210F391 for ; Mon, 29 Aug 2022 15:15:13 +0000 (UTC) Date: Mon, 29 Aug 2022 15:15:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1661786112; x=1662045312; bh=EEkAXvkmbHxeai88mh9TxAx4tKP8/BdSF8aQZBkGoLg=; h=Date:To:From:Reply-To:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=LhLEH+X7btfZOwGdoaB0VhYsaVuMkYxGrPvKeegTyB+bTGGnFqGgTLPq24YhCNBZw 67fuKeQjGGHC85rgoVH/RdFsG/uPSAPX9LEqIIZXa5AWtE2YcwOMaGCXJZsmrdPTnI hGFSLK/xYFwcWmJ4M4D2Awl9nS1co704wFQfHac5XY2yXsNb9zxf1ABJ5qcmwBo+DO svhBsoOGX/wf9+XmvqAgzwEAltqS5bF/FwHXIxk1qC4xAtKsxKk0dhADB9PWch9veR F8T1juDC8enyXWNtQw6SFtPSdd+QtAhndAU6ClFXEoLVAeaaUDi97Zb9kUXjszZ4Eb FyoL0s+YW4Jyg== To: dri-devel@lists.freedesktop.org From: Simon Ser Subject: [PATCH v2 3/3] drm/bridge: log message on atomic_check() and mode_fixup() failure Message-ID: <20220829151451.152114-3-contact@emersion.fr> In-Reply-To: <20220829151451.152114-1-contact@emersion.fr> References: <20220829151451.152114-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This helps user-space understand why an atomic commit fails. v2: new patch Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_bridge.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 1545c50fd1c8..c41c728b0c28 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -830,12 +830,26 @@ static int drm_atomic_bridge_check(struct drm_bridge *bridge, ret = bridge->funcs->atomic_check(bridge, bridge_state, crtc_state, conn_state); - if (ret) + if (ret) { + drm_dbg_atomic(bridge->dev, + "bridge driver check failed for [CRTC:%d:%s] and [CONNECTOR:%d:%s]\n", + crtc_state->crtc->base.id, + crtc_state->crtc->name, + conn_state->connector->base.id, + conn_state->connector->name); return ret; + } } else if (bridge->funcs->mode_fixup) { if (!bridge->funcs->mode_fixup(bridge, &crtc_state->mode, - &crtc_state->adjusted_mode)) + &crtc_state->adjusted_mode)) { + drm_dbg_atomic(bridge->dev, + "bridge mode fixup failed for [CRTC:%d:%s] and [CONNECTOR:%d:%s]\n", + crtc_state->crtc->base.id, + crtc_state->crtc->name, + conn_state->connector->base.id, + conn_state->connector->name); return -EINVAL; + } } return 0;