| Message ID | 20221010073803.88244-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/amd/display: Simplify bool conversion | expand |
On 2022-10-10 03:38, Yang Li wrote: > The result of 'pwr_status == 0' is Boolean, and the question mark > expression is redundant. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > index 955ca273cfe1..cbda458bf040 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > @@ -1401,7 +1401,7 @@ bool dcn32_dsc_pg_status( > break; > } > > - return pwr_status == 0 ? true : false; > + return pwr_status == 0; > } > > void dcn32_update_dsc_pg(struct dc *dc,
Applied. Thanks! Alex On Tue, Oct 11, 2022 at 11:27 AM Harry Wentland <harry.wentland@amd.com> wrote: > > On 2022-10-10 03:38, Yang Li wrote: > > The result of 'pwr_status == 0' is Boolean, and the question mark > > expression is redundant. > > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354 > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > > index 955ca273cfe1..cbda458bf040 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c > > @@ -1401,7 +1401,7 @@ bool dcn32_dsc_pg_status( > > break; > > } > > > > - return pwr_status == 0 ? true : false; > > + return pwr_status == 0; > > } > > > > void dcn32_update_dsc_pg(struct dc *dc, >
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c index 955ca273cfe1..cbda458bf040 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c @@ -1401,7 +1401,7 @@ bool dcn32_dsc_pg_status( break; } - return pwr_status == 0 ? true : false; + return pwr_status == 0; } void dcn32_update_dsc_pg(struct dc *dc,
The result of 'pwr_status == 0' is Boolean, and the question mark expression is redundant. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)