From patchwork Wed Oct 19 14:37:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 13011874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36BC5C433FE for ; Wed, 19 Oct 2022 14:38:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B17110F244; Wed, 19 Oct 2022 14:38:15 +0000 (UTC) Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id C008210F259 for ; Wed, 19 Oct 2022 14:38:04 +0000 (UTC) Date: Wed, 19 Oct 2022 14:37:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1666190283; x=1666449483; bh=PDxabIOW9zboILGrHVwtaZSKqlTEi/EeacCbHYBWwm0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=EVqglfItFfSyWz9tFM17Xvidg8Tv49Cq12CnXH1MAcgTMgjkrNUe32uA1hMzWIzr8 nH55kLLYE57DkJv/6BSw8MQ8Ctcuw+fBD6RYv0O24qMugzQwGiWClYRYJz4lT5qWL1 KjLjf78HWCh2CUu4yC+bZVIHSPE8CKSZ3IWM0fH5YCzhROpkjU67eB1D2uX1tVCeEO 3wRMMmZb4BhwU0cXYeL1CZJiYMYJOTrk+LlaR1w/559WilyOioNaWd6YckukJDM8LD jJLmA+5xhhPggxQ4iqTanmBUR0lY/AGAu9KK4qktJGSZdLLz6sJIc0pbDhYUUGxnAl aT39t8c68s8RQ== To: dri-devel@lists.freedesktop.org From: Simon Ser Subject: [PATCH 3/7] drm/atomic: log when getting/setting unknown properties Message-ID: <20221019143736.267324-3-contact@emersion.fr> In-Reply-To: <20221019143736.267324-1-contact@emersion.fr> References: <20221019143736.267324-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Jani Nikula --- drivers/gpu/drm/drm_atomic_uapi.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 826cb2212b26..39f3f491c148 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -498,8 +498,13 @@ drm_atomic_crtc_get_property(struct drm_crtc *crtc, *val = state->scaling_filter; else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val); - else + else { + drm_dbg_atomic(dev, + "[CRTC:%d:%s] unknown property [PROP:%d:%s]\n", + crtc->base.id, crtc->name, + property->base.id, property->name); return -EINVAL; + } return 0; } @@ -645,6 +650,10 @@ drm_atomic_plane_get_property(struct drm_plane *plane, } else if (plane->funcs->atomic_get_property) { return plane->funcs->atomic_get_property(plane, state, property, val); } else { + drm_dbg_atomic(dev, + "[PLANE:%d:%s] unknown property [PROP:%d:%s]\n", + plane->base.id, plane->name, + property->base.id, property->name); return -EINVAL; } @@ -861,6 +870,10 @@ drm_atomic_connector_get_property(struct drm_connector *connector, return connector->funcs->atomic_get_property(connector, state, property, val); } else { + drm_dbg_atomic(dev, + "[CONNECTOR:%d:%s] unknown property [PROP:%d:%s]\n", + connector->base.id, connector->name, + property->base.id, property->name); return -EINVAL; } @@ -899,6 +912,7 @@ int drm_atomic_get_property(struct drm_mode_object *obj, break; } default: + drm_dbg_atomic(dev, "[OBJECT:%d] has no properties\n", obj->id); ret = -EINVAL; break; } @@ -1035,6 +1049,7 @@ int drm_atomic_set_property(struct drm_atomic_state *state, break; } default: + drm_dbg_atomic(prop->dev, "[OBJECT:%d] has no properties\n", obj->id); ret = -EINVAL; break; }