From patchwork Wed Oct 19 14:38:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 13011876 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E8B7C43219 for ; Wed, 19 Oct 2022 14:38:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E88C10EAF8; Wed, 19 Oct 2022 14:38:37 +0000 (UTC) Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5FD110EAF8 for ; Wed, 19 Oct 2022 14:38:28 +0000 (UTC) Date: Wed, 19 Oct 2022 14:38:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1666190307; x=1666449507; bh=AA+aPRXipHH521FkMJp0Bfj9uMGIe6KWk2aFLsIW4sE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=bFpxi4Y77zpDkNxE5InV6UC3AWdjKDmvD7z0Yk7rv0bxq6WllOt4J/YgD1NbC8t8u yFKR/BL46UR1IShWQUENO+TOmtFQ9GG1CTVlVLu6OKuK9srei2IXW9lsPf2GYlO/5b /131iRkmxX7Tlq1Dkq1KzI17rntFAh6Sj/CTMDyb0x8G4JMsqrJ2dIjW4o16a12CQh W3em5r7r2L9O4FRCCfFOGBXoP8aZtRLXznmJnrsjKfi2Vq+iStOuV50Q4rnCy8IKsR APi2pqGoItX0n5Js9O6OFJb7yKPJp4l1mGGRpI5SghyB2dgCfaNQctqxwHFr+4ekaX ciBnp42QBFy+A== To: dri-devel@lists.freedesktop.org From: Simon Ser Subject: [PATCH 6/7] drm/atomic: log when page-flip is requested without CRTCs Message-ID: <20221019143736.267324-6-contact@emersion.fr> In-Reply-To: <20221019143736.267324-1-contact@emersion.fr> References: <20221019143736.267324-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Jani Nikula --- drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 3df3f7ba0af3..b996351beb57 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1261,8 +1261,10 @@ static int prepare_signaling(struct drm_device *dev, * Having this flag means user mode pends on event which will never * reach due to lack of at least one CRTC for signaling */ - if (c == 0 && (arg->flags & DRM_MODE_PAGE_FLIP_EVENT)) + if (c == 0 && (arg->flags & DRM_MODE_PAGE_FLIP_EVENT)) { + drm_dbg_atomic(dev, "need at least one CRTC for DRM_MODE_PAGE_FLIP_EVENT"); return -EINVAL; + } return 0; }