| Message ID | 20221024141210.67784-1-dmitry.osipenko@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ACPI: video: Fix missing native backlight on Chromebooks | expand |
Hi, On 10/24/22 16:12, Dmitry Osipenko wrote: > Chromebooks don't have backlight in ACPI table, they suppose to use > native backlight in this case. Check presence of the CrOS embedded > controller ACPI device and prefer the native backlight if EC found. > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > --- > > Changelog: > > v2: - Added explanatory comment to the code and added check for the > native backlight presence, like was requested by Hans de Goede. Thanks this version looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Rafael, can you pick this up and send it in a fixes pull-req for 6.1 to Linus? Or shall I pick this one up and include it in my next pull-req? Regards, Hans > > drivers/acpi/video_detect.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 0d9064a9804c..9cd8797d12bb 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > { }, > }; > > +static bool google_cros_ec_present(void) > +{ > + return acpi_dev_found("GOOG0004"); > +} > + > /* > * Determine which type of backlight interface to use on this system, > * First check cmdline, then dmi quirks, then do autodetect. > @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) > return acpi_backlight_video; > } > > + /* > + * Chromebooks that don't have backlight handle in ACPI table > + * are supposed to use native backlight if it's available. > + */ > + if (google_cros_ec_present() && native_available) > + return acpi_backlight_native; > + > /* No ACPI video (old hw), use vendor specific fw methods. */ > return acpi_backlight_vendor; > }
On Mon, Oct 24, 2022 at 4:32 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 10/24/22 16:12, Dmitry Osipenko wrote: > > Chromebooks don't have backlight in ACPI table, they suppose to use > > native backlight in this case. Check presence of the CrOS embedded > > controller ACPI device and prefer the native backlight if EC found. > > > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > > Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") > > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > > --- > > > > Changelog: > > > > v2: - Added explanatory comment to the code and added check for the > > native backlight presence, like was requested by Hans de Goede. > > Thanks this version looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > Rafael, can you pick this up and send it in a fixes pull-req > for 6.1 to Linus? Or shall I pick this one up and include it > in my next pull-req? It would be better if you could pick this up IMV, so please free to add Acled-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> to it. Thanks! > > > > drivers/acpi/video_detect.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > > index 0d9064a9804c..9cd8797d12bb 100644 > > --- a/drivers/acpi/video_detect.c > > +++ b/drivers/acpi/video_detect.c > > @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > > { }, > > }; > > > > +static bool google_cros_ec_present(void) > > +{ > > + return acpi_dev_found("GOOG0004"); > > +} > > + > > /* > > * Determine which type of backlight interface to use on this system, > > * First check cmdline, then dmi quirks, then do autodetect. > > @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) > > return acpi_backlight_video; > > } > > > > + /* > > + * Chromebooks that don't have backlight handle in ACPI table > > + * are supposed to use native backlight if it's available. > > + */ > > + if (google_cros_ec_present() && native_available) > > + return acpi_backlight_native; > > + > > /* No ACPI video (old hw), use vendor specific fw methods. */ > > return acpi_backlight_vendor; > > } >
On 2022/10/24 23:12, Dmitry Osipenko wrote: > Chromebooks don't have backlight in ACPI table, they suppose to use > native backlight in this case. Check presence of the CrOS embedded > controller ACPI device and prefer the native backlight if EC found. > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > --- > > Changelog: > > v2: - Added explanatory comment to the code and added check for the > native backlight presence, like was requested by Hans de Goede. > > drivers/acpi/video_detect.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 0d9064a9804c..9cd8797d12bb 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > { }, > }; > > +static bool google_cros_ec_present(void) > +{ > + return acpi_dev_found("GOOG0004"); > +} > + > /* > * Determine which type of backlight interface to use on this system, > * First check cmdline, then dmi quirks, then do autodetect. > @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) > return acpi_backlight_video; > } > > + /* > + * Chromebooks that don't have backlight handle in ACPI table > + * are supposed to use native backlight if it's available. > + */ > + if (google_cros_ec_present() && native_available) > + return acpi_backlight_native; > + > /* No ACPI video (old hw), use vendor specific fw methods. */ > return acpi_backlight_vendor; > } Hi, The native_available check does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination. Regards, Akihiko Odaki
Hi, On 10/24/22 16:52, Akihiko Odaki wrote: > On 2022/10/24 23:12, Dmitry Osipenko wrote: >> Chromebooks don't have backlight in ACPI table, they suppose to use >> native backlight in this case. Check presence of the CrOS embedded >> controller ACPI device and prefer the native backlight if EC found. >> >> Suggested-by: Hans de Goede <hdegoede@redhat.com> >> Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> >> --- >> >> Changelog: >> >> v2: - Added explanatory comment to the code and added check for the >> native backlight presence, like was requested by Hans de Goede. >> >> drivers/acpi/video_detect.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >> index 0d9064a9804c..9cd8797d12bb 100644 >> --- a/drivers/acpi/video_detect.c >> +++ b/drivers/acpi/video_detect.c >> @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { >> { }, >> }; >> +static bool google_cros_ec_present(void) >> +{ >> + return acpi_dev_found("GOOG0004"); >> +} >> + >> /* >> * Determine which type of backlight interface to use on this system, >> * First check cmdline, then dmi quirks, then do autodetect. >> @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) >> return acpi_backlight_video; >> } >> + /* >> + * Chromebooks that don't have backlight handle in ACPI table >> + * are supposed to use native backlight if it's available. >> + */ >> + if (google_cros_ec_present() && native_available) >> + return acpi_backlight_native; >> + >> /* No ACPI video (old hw), use vendor specific fw methods. */ >> return acpi_backlight_vendor; >> } > > Hi, > > The native_available check does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination. There are no drivers providing acpi_backlight_vendor functionality on chromebooks. All the drivers providing acpi_backlight_vendor functionality use vendor (Dell, Acer, Asus, etc.) specific firmware (smbios, EC bitbanging or ACPI) backlight control method which are not available on CoreBoot based ChromeBooks. Also notice that the theoretical problem of a vendor driver loading first was already present before the backlight refactor which landed in 6.1 and this has never been an issue. Regards, Hans
On 2022/10/24 23:59, Hans de Goede wrote: > Hi, > > On 10/24/22 16:52, Akihiko Odaki wrote: >> On 2022/10/24 23:12, Dmitry Osipenko wrote: >>> Chromebooks don't have backlight in ACPI table, they suppose to use >>> native backlight in this case. Check presence of the CrOS embedded >>> controller ACPI device and prefer the native backlight if EC found. >>> >>> Suggested-by: Hans de Goede <hdegoede@redhat.com> >>> Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") >>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>> --- >>> >>> Changelog: >>> >>> v2: - Added explanatory comment to the code and added check for the >>> native backlight presence, like was requested by Hans de Goede. >>> >>> drivers/acpi/video_detect.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >>> index 0d9064a9804c..9cd8797d12bb 100644 >>> --- a/drivers/acpi/video_detect.c >>> +++ b/drivers/acpi/video_detect.c >>> @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { >>> { }, >>> }; >>> +static bool google_cros_ec_present(void) >>> +{ >>> + return acpi_dev_found("GOOG0004"); >>> +} >>> + >>> /* >>> * Determine which type of backlight interface to use on this system, >>> * First check cmdline, then dmi quirks, then do autodetect. >>> @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) >>> return acpi_backlight_video; >>> } >>> + /* >>> + * Chromebooks that don't have backlight handle in ACPI table >>> + * are supposed to use native backlight if it's available. >>> + */ >>> + if (google_cros_ec_present() && native_available) >>> + return acpi_backlight_native; >>> + >>> /* No ACPI video (old hw), use vendor specific fw methods. */ >>> return acpi_backlight_vendor; >>> } >> >> Hi, >> >> The native_available check does not prevent duplicate registration if vendor backlight registers first. It was enough for the combination of ACPI video and native because ACPI video delays its registration, but it is not the case for vendor/native combination. > > There are no drivers providing acpi_backlight_vendor functionality on chromebooks. > > All the drivers providing acpi_backlight_vendor functionality use vendor (Dell, Acer, Asus, etc.) > specific firmware (smbios, EC bitbanging or ACPI) backlight control method which are not available > on CoreBoot based ChromeBooks. Hi, Isn't the "native_available" check is for the case when acpi_backlight_vendor functionality gets implemented on Chromebooks? If it is, you don't want it to get broken when it actually happens. If you can ignore the case, native_available check is simply unnecessary. > > Also notice that the theoretical problem of a vendor driver loading first was already present > before the backlight refactor which landed in 6.1 and this has never been an issue. The situation is even a bit better than it was before the refactor since duplication happened even when vendor driver loads later if I understand it correctly. Regards, Akihiko Odaki > > Regards, > > Hans >
Hi, On 10/24/22 16:45, Rafael J. Wysocki wrote: > On Mon, Oct 24, 2022 at 4:32 PM Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi, >> >> On 10/24/22 16:12, Dmitry Osipenko wrote: >>> Chromebooks don't have backlight in ACPI table, they suppose to use >>> native backlight in this case. Check presence of the CrOS embedded >>> controller ACPI device and prefer the native backlight if EC found. >>> >>> Suggested-by: Hans de Goede <hdegoede@redhat.com> >>> Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") >>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> >>> --- >>> >>> Changelog: >>> >>> v2: - Added explanatory comment to the code and added check for the >>> native backlight presence, like was requested by Hans de Goede. >> >> Thanks this version looks good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> >> Rafael, can you pick this up and send it in a fixes pull-req >> for 6.1 to Linus? Or shall I pick this one up and include it >> in my next pull-req? > > It would be better if you could pick this up IMV, so please free to add > > Acled-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Ok, I've merged this now and I'll send out fixes pull-req with this to Linus before coming Friday. Dmitry, Thank you for your patch, I've applied this patch to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Regards, Hans > > to it. > > Thanks! > >>> >>> drivers/acpi/video_detect.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c >>> index 0d9064a9804c..9cd8797d12bb 100644 >>> --- a/drivers/acpi/video_detect.c >>> +++ b/drivers/acpi/video_detect.c >>> @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { >>> { }, >>> }; >>> >>> +static bool google_cros_ec_present(void) >>> +{ >>> + return acpi_dev_found("GOOG0004"); >>> +} >>> + >>> /* >>> * Determine which type of backlight interface to use on this system, >>> * First check cmdline, then dmi quirks, then do autodetect. >>> @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) >>> return acpi_backlight_video; >>> } >>> >>> + /* >>> + * Chromebooks that don't have backlight handle in ACPI table >>> + * are supposed to use native backlight if it's available. >>> + */ >>> + if (google_cros_ec_present() && native_available) >>> + return acpi_backlight_native; >>> + >>> /* No ACPI video (old hw), use vendor specific fw methods. */ >>> return acpi_backlight_vendor; >>> } >> >
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 0d9064a9804c..9cd8797d12bb 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -668,6 +668,11 @@ static const struct dmi_system_id video_detect_dmi_table[] = { { }, }; +static bool google_cros_ec_present(void) +{ + return acpi_dev_found("GOOG0004"); +} + /* * Determine which type of backlight interface to use on this system, * First check cmdline, then dmi quirks, then do autodetect. @@ -730,6 +735,13 @@ static enum acpi_backlight_type __acpi_video_get_backlight_type(bool native) return acpi_backlight_video; } + /* + * Chromebooks that don't have backlight handle in ACPI table + * are supposed to use native backlight if it's available. + */ + if (google_cros_ec_present() && native_available) + return acpi_backlight_native; + /* No ACPI video (old hw), use vendor specific fw methods. */ return acpi_backlight_vendor; }
Chromebooks don't have backlight in ACPI table, they suppose to use native backlight in this case. Check presence of the CrOS embedded controller ACPI device and prefer the native backlight if EC found. Suggested-by: Hans de Goede <hdegoede@redhat.com> Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> --- Changelog: v2: - Added explanatory comment to the code and added check for the native backlight presence, like was requested by Hans de Goede. drivers/acpi/video_detect.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)