| Message ID | 20221107235654.1769462-8-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint | expand |
On 08/11/2022 02:56, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of clocks. > > To facilitate documenting the clocks add the following compatible strings > > - qcom,mdss-dsi-ctrl-apq8064 Generic comment: I think we'd better follow the arm/qcom-soc.yaml and use qcom,soc-something as compat string. This would leave us with qcom,apq8064-dsi-ctrl I'm not sure if we want to follow the qcm2290 approach and encode the DSI ctrl revision here (6g vs v2). > - qcom,mdss-dsi-ctrl-msm8916 > - qcom,mdss-dsi-ctrl-msm8974 > - qcom,mdss-dsi-ctrl-msm8996 > - qcom,mdss-dsi-ctrl-sc7180 > - qcom,mdss-dsi-ctrl-sc7280 > - qcom,mdss-dsi-ctrl-sdm630 > - qcom,mdss-dsi-ctrl-sdm660 > - qcom,mdss-dsi-ctrl-sdm845 > - qcom,mdss-dsi-ctrl-sm8250 > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-controller-main.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index b35130a77b43e..9db3e63acda3d 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -17,6 +17,16 @@ properties: > enum: > - qcom,dsi-ctrl-6g-qcm2290 > - qcom,mdss-dsi-ctrl > + - qcom,mdss-dsi-ctrl-apq8064 > + - qcom,mdss-dsi-ctrl-msm8916 > + - qcom,mdss-dsi-ctrl-msm8974 > + - qcom,mdss-dsi-ctrl-msm8996 > + - qcom,mdss-dsi-ctrl-sc7180 > + - qcom,mdss-dsi-ctrl-sc7280 > + - qcom,mdss-dsi-ctrl-sdm630 > + - qcom,mdss-dsi-ctrl-sdm660 > + - qcom,mdss-dsi-ctrl-sdm845 > + - qcom,mdss-dsi-ctrl-sm8250 > > reg: > maxItems: 1
On 08/11/2022 13:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significant differences >> in the number of clocks. >> >> To facilitate documenting the clocks add the following compatible strings >> >> - qcom,mdss-dsi-ctrl-apq8064 > > Generic comment: I think we'd better follow the arm/qcom-soc.yaml and > use qcom,soc-something as compat string. This would leave us with > qcom,apq8064-dsi-ctrl That's a requirement. Only existing patterns are allowed to continue, but here all there is no such pattern. Best regards, Krzysztof
On 08/11/2022 12:46, Dmitry Baryshkov wrote: > On 08/11/2022 02:56, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significant >> differences >> in the number of clocks. >> >> To facilitate documenting the clocks add the following compatible strings >> >> - qcom,mdss-dsi-ctrl-apq8064 > > Generic comment: I think we'd better follow the arm/qcom-soc.yaml and > use qcom,soc-something as compat string. This would leave us with > qcom,apq8064-dsi-ctrl > > I'm not sure if we want to follow the qcm2290 approach and encode the > DSI ctrl revision here (6g vs v2). For qcm2290 I'm thinking qcm2290-dsi-ctrl - without the 6g piece. a) Nobody is using the compat at the moment b) I'm not sure what - if any real information the silicon version number conveys here. + Loic, Shawn --- bod
On 18/11/2022 15:29, Bryan O'Donoghue wrote: > On 08/11/2022 12:46, Dmitry Baryshkov wrote: >> On 08/11/2022 02:56, Bryan O'Donoghue wrote: >>> Currently we do not differentiate between the various users of the >>> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >>> compatible string but, the hardware does have some significant >>> differences >>> in the number of clocks. >>> >>> To facilitate documenting the clocks add the following compatible >>> strings >>> >>> - qcom,mdss-dsi-ctrl-apq8064 >> >> Generic comment: I think we'd better follow the arm/qcom-soc.yaml and >> use qcom,soc-something as compat string. This would leave us with >> qcom,apq8064-dsi-ctrl >> >> I'm not sure if we want to follow the qcm2290 approach and encode the >> DSI ctrl revision here (6g vs v2). > > For qcm2290 I'm thinking qcm2290-dsi-ctrl - without the 6g piece. This sounds good too. > > a) Nobody is using the compat at the moment > b) I'm not sure what - if any real information the silicon version > number conveys here. > > + Loic, Shawn > > --- > bod >
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index b35130a77b43e..9db3e63acda3d 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -17,6 +17,16 @@ properties: enum: - qcom,dsi-ctrl-6g-qcm2290 - qcom,mdss-dsi-ctrl + - qcom,mdss-dsi-ctrl-apq8064 + - qcom,mdss-dsi-ctrl-msm8916 + - qcom,mdss-dsi-ctrl-msm8974 + - qcom,mdss-dsi-ctrl-msm8996 + - qcom,mdss-dsi-ctrl-sc7180 + - qcom,mdss-dsi-ctrl-sc7280 + - qcom,mdss-dsi-ctrl-sdm630 + - qcom,mdss-dsi-ctrl-sdm660 + - qcom,mdss-dsi-ctrl-sdm845 + - qcom,mdss-dsi-ctrl-sm8250 reg: maxItems: 1
Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compatible strings - qcom,mdss-dsi-ctrl-apq8064 - qcom,mdss-dsi-ctrl-msm8916 - qcom,mdss-dsi-ctrl-msm8974 - qcom,mdss-dsi-ctrl-msm8996 - qcom,mdss-dsi-ctrl-sc7180 - qcom,mdss-dsi-ctrl-sc7280 - qcom,mdss-dsi-ctrl-sdm630 - qcom,mdss-dsi-ctrl-sdm660 - qcom,mdss-dsi-ctrl-sdm845 - qcom,mdss-dsi-ctrl-sm8250 Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/display/msm/dsi-controller-main.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)