| Message ID | 20221116091712.1309651-1-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drm/tests: Include helpers header | expand |
Hi Maxime, On 11/16/22 06:17, Maxime Ripard wrote: > The kunit helpers code weren't including its header, leading to a > warning that no previous prototype had been defined for public > functions. > > Include the matching header to fix the warning. > > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Reviewed-by: Maíra Canal <mairacanal@riseup.net> Best Regards, - Maíra Canal > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > index d3f0d681b685..dbd8ec24d4be 100644 > --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > @@ -5,6 +5,8 @@ > > #include <linux/device.h> > > +#include "drm_kunit_helpers.h" > + > struct kunit_dev { > struct drm_device base; > };
On Wed, 16 Nov 2022 10:17:10 +0100, Maxime Ripard wrote: > The kunit helpers code weren't including its header, leading to a > warning that no previous prototype had been defined for public > functions. > > Include the matching header to fix the warning. > > > [...] Applied to local tree (tmp). Thanks! Maxime
diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c index d3f0d681b685..dbd8ec24d4be 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -5,6 +5,8 @@ #include <linux/device.h> +#include "drm_kunit_helpers.h" + struct kunit_dev { struct drm_device base; };
The kunit helpers code weren't including its header, leading to a warning that no previous prototype had been defined for public functions. Include the matching header to fix the warning. Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ 1 file changed, 2 insertions(+)