| Message ID | 20221207151400.1572582-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp | expand |
On 12/7/22 16:13, Alexander Stein wrote: > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 876015a44a1e6..793e8eccf8b8b 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -70,7 +70,9 @@ allOf: > properties: > compatible: > contains: > - const: fsl,imx6sx-lcdif > + enum: > + - fsl,imx6sx-lcdif > + - fsl,imx8mp-lcdif > then: > properties: > clocks: Reviewed-by: Marek Vasut <marex@denx.de> btw you might want to update the clock-names and clock proerty order in imx8mp.dtsi to match the clock-names order in these bindings.
On Wed, 07 Dec 2022 16:13:59 +0100, Alexander Stein wrote: > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Hello Marek, Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut: > On 12/7/22 16:13, Alexander Stein wrote: > > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & > > clock-names. > > > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > > 876015a44a1e6..793e8eccf8b8b 100644 > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > > @@ -70,7 +70,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: fsl,imx6sx-lcdif > > + enum: > > + - fsl,imx6sx-lcdif > > + - fsl,imx8mp-lcdif > > > > then: > > properties: > > clocks: > Reviewed-by: Marek Vasut <marex@denx.de> Thanks! > btw you might want to update the clock-names and clock proerty order in > imx8mp.dtsi to match the clock-names order in these bindings. The lcdif nodes are not yet in linux-next ;-) So its probably a local commit on your side. But yes, the upcoming patches will address this. Best regards, Alexander
On 12/8/22 07:31, Alexander Stein wrote: > Hello Marek, > > Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut: >> On 12/7/22 16:13, Alexander Stein wrote: >>> i.MX8MP uses 3 clocks, so soften the restrictions for clocks & >>> clock-names. >>> >>> Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> --- >>> >>> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index >>> 876015a44a1e6..793e8eccf8b8b 100644 >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> >>> @@ -70,7 +70,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: fsl,imx6sx-lcdif >>> + enum: >>> + - fsl,imx6sx-lcdif >>> + - fsl,imx8mp-lcdif >>> >>> then: >>> properties: >>> clocks: >> Reviewed-by: Marek Vasut <marex@denx.de> > > Thanks! > >> btw you might want to update the clock-names and clock proerty order in >> imx8mp.dtsi to match the clock-names order in these bindings. > > The lcdif nodes are not yet in linux-next ;-) So its probably a local commit > on your side. But yes, the upcoming patches will address this. Ah, right, seems they are still pending HDMI and DSIM addition. Sorry for the noise.
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 876015a44a1e6..793e8eccf8b8b 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -70,7 +70,9 @@ allOf: properties: compatible: contains: - const: fsl,imx6sx-lcdif + enum: + - fsl,imx6sx-lcdif + - fsl,imx8mp-lcdif then: properties: clocks:
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)