diff mbox series

drm/nouveau/mc/ga100: make ga100_mc_device static

Message ID 20221229155249.669436-1-ben-linux@fluff.org (mailing list archive)
State New, archived
Headers show
Series drm/nouveau/mc/ga100: make ga100_mc_device static | expand

Commit Message

Ben Dooks Dec. 29, 2022, 3:52 p.m. UTC
Make ga100_mc_device static as it isn't exported, to
fix the following sparse warning:

drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol 'ga100_mc_device' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Karol Herbst April 11, 2023, 2:05 p.m. UTC | #1
Reviewed-by: Karol Herbst <kherbst@redhat.com>

On Thu, Dec 29, 2022 at 4:52 PM Ben Dooks <ben-linux@fluff.org> wrote:
>
> Make ga100_mc_device static as it isn't exported, to
> fix the following sparse warning:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol 'ga100_mc_device' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
> index 1e2eabec1a76..5d28d30d09d5 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
> @@ -47,7 +47,7 @@ ga100_mc_device_enabled(struct nvkm_mc *mc, u32 mask)
>         return (nvkm_rd32(mc->subdev.device, 0x000600) & mask) == mask;
>  }
>
> -const struct nvkm_mc_device_func
> +static const struct nvkm_mc_device_func
>  ga100_mc_device = {
>         .enabled = ga100_mc_device_enabled,
>         .enable = ga100_mc_device_enable,
> --
> 2.39.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
index 1e2eabec1a76..5d28d30d09d5 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c
@@ -47,7 +47,7 @@  ga100_mc_device_enabled(struct nvkm_mc *mc, u32 mask)
 	return (nvkm_rd32(mc->subdev.device, 0x000600) & mask) == mask;
 }
 
-const struct nvkm_mc_device_func
+static const struct nvkm_mc_device_func
 ga100_mc_device = {
 	.enabled = ga100_mc_device_enabled,
 	.enable = ga100_mc_device_enable,