| Message ID | 20230112033823.24901-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/dpu: Remove some unused variables | expand |
On 12/01/2023 05:38, Jiapeng Chong wrote: > Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the > dpu_hw_catalog.c file, but not used elsewhere, so remove these unused > variables. > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused variable 'sm8350_regdma'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 16 ---------------- > 1 file changed, 16 deletions(-) NAK, the patch should change catalog entries to use correct regdma entries instead of deleting them.
On 1/11/2023 7:38 PM, Jiapeng Chong wrote: > Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the > dpu_hw_catalog.c file, but not used elsewhere, so remove these unused > variables. > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused variable 'sm8350_regdma'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> We should be adding the regdma entries to .dma_cfg of these chipsets. > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 0f3da480b066..79bbef93948f 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -2026,14 +2026,6 @@ static const struct dpu_vbif_cfg sdm845_vbif[] = { > }, > }; > > -static const struct dpu_reg_dma_cfg sc8280xp_regdma = { > - .base = 0x0, > - .version = 0x00020000, > - .trigger_sel_off = 0x119c, > - .xin_id = 7, > - .clk_ctrl = DPU_CLK_CTRL_REG_DMA, > -}; > - > static const struct dpu_reg_dma_cfg sdm845_regdma = { > .base = 0x0, .version = 0x1, .trigger_sel_off = 0x119c > }; > @@ -2050,14 +2042,6 @@ static const struct dpu_reg_dma_cfg sm8250_regdma = { > .clk_ctrl = DPU_CLK_CTRL_REG_DMA, > }; > > -static const struct dpu_reg_dma_cfg sm8350_regdma = { > - .base = 0x400, > - .version = 0x00020000, > - .trigger_sel_off = 0x119c, > - .xin_id = 7, > - .clk_ctrl = DPU_CLK_CTRL_REG_DMA, > -}; > - > static const struct dpu_reg_dma_cfg sm8450_regdma = { > .base = 0x0, > .version = 0x00020000,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index 0f3da480b066..79bbef93948f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -2026,14 +2026,6 @@ static const struct dpu_vbif_cfg sdm845_vbif[] = { }, }; -static const struct dpu_reg_dma_cfg sc8280xp_regdma = { - .base = 0x0, - .version = 0x00020000, - .trigger_sel_off = 0x119c, - .xin_id = 7, - .clk_ctrl = DPU_CLK_CTRL_REG_DMA, -}; - static const struct dpu_reg_dma_cfg sdm845_regdma = { .base = 0x0, .version = 0x1, .trigger_sel_off = 0x119c }; @@ -2050,14 +2042,6 @@ static const struct dpu_reg_dma_cfg sm8250_regdma = { .clk_ctrl = DPU_CLK_CTRL_REG_DMA, }; -static const struct dpu_reg_dma_cfg sm8350_regdma = { - .base = 0x400, - .version = 0x00020000, - .trigger_sel_off = 0x119c, - .xin_id = 7, - .clk_ctrl = DPU_CLK_CTRL_REG_DMA, -}; - static const struct dpu_reg_dma_cfg sm8450_regdma = { .base = 0x0, .version = 0x00020000,
Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the dpu_hw_catalog.c file, but not used elsewhere, so remove these unused variables. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused variable 'sm8350_regdma'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 16 ---------------- 1 file changed, 16 deletions(-)