| Message ID | 20230116115132.348961-1-konrad.dybcio@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY | expand |
On 16/01/2023 12:51, Konrad Dybcio wrote: > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. I think we should have an explicit `if compatible then required: vdds-supply' clause. WDYT? > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index 9c9184f94c44..8e9031bbde73 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -48,7 +48,6 @@ required: > - compatible > - reg > - reg-names > - - vdds-supply > > unevaluatedProperties: false > > -- > 2.39.0 >
On 16.01.2023 13:52, Dmitry Baryshkov wrote: > On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm >> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, >> which is voted for in the DSI ctrl node. > > I think we should have an explicit `if compatible then required: > vdds-supply' clause. WDYT? Well, the driver will still probe and function without it, so I'm not sure if it's strictly required.. Konrad > >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml >> index 9c9184f94c44..8e9031bbde73 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml >> @@ -48,7 +48,6 @@ required: >> - compatible >> - reg >> - reg-names >> - - vdds-supply >> >> unevaluatedProperties: false >> >> -- >> 2.39.0 >> > >
On Mon, 16 Jan 2023 12:51:32 +0100, Konrad Dybcio wrote: > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. > > Applied, thanks! [1/1] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY https://gitlab.freedesktop.org/lumag/msm/-/commit/4ff00ebb193a Best regards,
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml index 9c9184f94c44..8e9031bbde73 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml @@ -48,7 +48,6 @@ required: - compatible - reg - reg-names - - vdds-supply unevaluatedProperties: false
On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, which is voted for in the DSI ctrl node. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 - 1 file changed, 1 deletion(-)