| Message ID | 20230217-topic-lenovo-panel-v2-1-2e2c64729330@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for Lenovo NT36523W BOE panel | expand |
On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ > XiaoXin Pad devices. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> (...) > +$id: http://devicetree.org/schemas/display/panel/lenovo,nt36523w-boe-j606.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NT36523W BOE panel found on Lenovo J606 devices It's a Novatek NT36523 display controller-based device isn't it? I would reflect that in the title or at least the description. > + > +maintainers: > + - Konrad Dybcio <konrad.dybcio@linaro.org> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: lenovo,nt36523w-boe-j606 > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + vddio-supply: true > + reset-gpios: true > + rotation: true > + port: true This is clearly (as can be seen from the magic in the driver) a Novatek NT36523 display controller, just configured differently. https://lore.kernel.org/lkml/20230220121258.10727-1-lujianhua000@gmail.com/T/ Why can't you just modify the existing nt36523 binding from Jianhua Lu by e.g. making these two non-required: - vddpos-supply - vddneg-supply It would not be helpful for driver writers to have two different bindings for similar hardware hand having to write code to handle different properties depending on which binding is used, so please unify into one binding by cooperating with Jianhua. Would it help if we merged Jianhua's binding so you can build on top? Yours, Linus Walleij
On 7.03.2023 23:08, Linus Walleij wrote: > On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > >> Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ >> XiaoXin Pad devices. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > (...) >> +$id: http://devicetree.org/schemas/display/panel/lenovo,nt36523w-boe-j606.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NT36523W BOE panel found on Lenovo J606 devices > > It's a Novatek NT36523 display controller-based device isn't it? > > I would reflect that in the title or at least the description. > >> + >> +maintainers: >> + - Konrad Dybcio <konrad.dybcio@linaro.org> >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: lenovo,nt36523w-boe-j606 >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + vddio-supply: true >> + reset-gpios: true >> + rotation: true >> + port: true > > This is clearly (as can be seen from the magic in the driver) a > Novatek NT36523 display controller, just configured differently. > https://lore.kernel.org/lkml/20230220121258.10727-1-lujianhua000@gmail.com/T/ > > Why can't you just modify the existing nt36523 binding from > Jianhua Lu by e.g. making these two non-required: > > - vddpos-supply > - vddneg-supply > > It would not be helpful for driver writers to have two different bindings > for similar hardware hand having to write code to handle different > properties depending on which binding is used, so please unify into > one binding by cooperating with Jianhua. I'll look into Jianhua's patchset and try to work atop that! > > Would it help if we merged Jianhua's binding so you can build on topYes please, the less out-of-tree dependencies the better.. > > Yours, > Linus Walleij
On Wed, Mar 8, 2023 at 12:02 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > It would not be helpful for driver writers to have two different bindings > > for similar hardware hand having to write code to handle different > > properties depending on which binding is used, so please unify into > > one binding by cooperating with Jianhua. > I'll look into Jianhua's patchset and try to work atop that! Jianhua's driver is merged to drm-misc-next so you can make your addendum now! https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c61093b56a2ff15e449e8af56e96dc5a312baf25 https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0993234a00451e0a5c3e47d8b0f2e01dac6cedbf Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml b/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml new file mode 100644 index 000000000000..43dcbe3f9f30 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/lenovo,nt36523w-boe-j606.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/lenovo,nt36523w-boe-j606.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NT36523W BOE panel found on Lenovo J606 devices + +maintainers: + - Konrad Dybcio <konrad.dybcio@linaro.org> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: lenovo,nt36523w-boe-j606 + + reg: + maxItems: 1 + description: DSI virtual channel + + vddio-supply: true + reset-gpios: true + rotation: true + port: true + +additionalProperties: false + +required: + - compatible + - reg + - vddio-supply + - reset-gpios + - port + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "lenovo,nt36523w-boe-j606"; + reg = <0>; + + reset-gpios = <&tlmm 82 GPIO_ACTIVE_LOW>; + vddio-supply = <&pm6125_l9>; + + rotation = <180>; + + port { + panel0_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + }; +...