From patchwork Thu Feb 23 12:06:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13150197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D90C64ED8 for ; Thu, 23 Feb 2023 12:07:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DF5310EB6A; Thu, 23 Feb 2023 12:07:19 +0000 (UTC) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD88D10EB5F for ; Thu, 23 Feb 2023 12:07:00 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id f16so10556782ljq.10 for ; Thu, 23 Feb 2023 04:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=17Sj165m9p2RYNMuvknYM96FiMR5+0g8UyAYd2eSrwY=; b=OaVrt9YSvRtla+1dIiygzmlR3nNaVMFpvDn384L0qJWtksmJRQUDKCxaZZWVlQCfEC yVY/sTl7Z1my97KQY5cLljkTcCh5Hk1vepRrKpPNCuBfYy/njaK8cpcPLZF6P9k23RrX /whd3tqZjOeyigL/Piz4Tme2/HxhqOywVC7eefN9C+o45UMgCemRcIaLx7AjDucI2/fH aJRFbudDz7f0F7q2soV1Rqw4nVBnaf9hRuLKPWkq3Ewe+zthtl/V3DZBRagdQ3mC9+un yeV1cVpGh+DjODjNWd5768OSzpAJoyKiCx96d9mHeUS9JqOOLKta71LvPW/doxbxhdG2 THaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=17Sj165m9p2RYNMuvknYM96FiMR5+0g8UyAYd2eSrwY=; b=jmxC+qRA5nu0NvHa9rHJnIJ8HxUU1EgkOCZaI62KutWxTjRg8eAoLmqolXfNZxC5X/ 1tIafPw+qyEE87TK7o3SLP59t46c6SF687vOZQcu2DzbM/vAExbFJ53tpUjyykSiVU8h LE0/h+VuCWL/bYudrs6oWZFkz8NCLgrTrl4ir7v/nKvgBNyR0QfXM7CwXIeY2WN9t7JE ClYFb1TYpolTqzjSnvzhV5cM8SNZqqSXWjMUV61Ii+P5+Cm/UZsrGOriIg0eveaMU01f cLORh8XkvTXwxDX61tpbqWzmCHROVPPdmC5hM/SVg3IVuQCBArtrd7+x7p5ocXQAe1cQ 2E6Q== X-Gm-Message-State: AO0yUKWcMcgP49lB31/lfnyxfpBMcwx6q6I6O8Fy7QL6/JuelxxgdqCJ /bLtSZIs7GFtXmSvaDQj5QAB3Q== X-Google-Smtp-Source: AK7set8MP0MVTI3jKda/9hAxOgPBZ+85qvmspDgfRoXhIC5bbZP+ZlbqQXJvF9pw2sqjfvnn59QQEQ== X-Received: by 2002:a2e:7d08:0:b0:293:51ba:24b3 with SMTP id y8-20020a2e7d08000000b0029351ba24b3mr4316167ljc.41.1677154020326; Thu, 23 Feb 2023 04:07:00 -0800 (PST) Received: from [192.168.1.101] (abxi151.neoplus.adsl.tpnet.pl. [83.9.2.151]) by smtp.gmail.com with ESMTPSA id h23-20020a2ea497000000b0029599744c02sm414838lji.75.2023.02.23.04.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 04:07:00 -0800 (PST) From: Konrad Dybcio Date: Thu, 23 Feb 2023 13:06:44 +0100 Subject: [PATCH v3 10/15] drm/msm/a6xx: Fix A680 highest bank bit value MIME-Version: 1.0 Message-Id: <20230223-topic-gmuwrapper-v3-10-5be55a336819@linaro.org> References: <20230223-topic-gmuwrapper-v3-0-5be55a336819@linaro.org> In-Reply-To: <20230223-topic-gmuwrapper-v3-0-5be55a336819@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677154003; l=1043; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=XyF/fIhqGhaqw/LSLnLQoZLpoApnz2Tm2KTMjRETKS0=; b=KNcnjoD9rWmy5mT4YH7OnatzxLE4iAZRwnM2y6dLWueGTxPwo3uCMS0NPrLwqJpUq5uh442AJSwo cgRHrMA2AlIAq7g9yAw9JnDnekIYxgGTePs30xvYuP3cIFpemrAR X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" According to the vendor sources, it's equal to 16, which makes hbb_lo equal to 3. Fixes: 840d10b64dad ("drm: msm: Add 680 gpu to the adreno gpu list") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index b5017c56fa1b..2c4afecdd213 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -885,12 +885,18 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) hbb_lo = 2; } - if (adreno_is_a640_family(adreno_gpu)) { + if (adreno_is_a640(adreno_gpu)) { amsbc = 1; /* HBB = 15 */ hbb_lo = 2; } + if (adreno_is_a680(adreno_gpu)) { + amsbc = 1; + /* HBB = 16 */ + hbb_lo = 3; + } + if (adreno_is_a650(adreno_gpu) || adreno_is_a660(adreno_gpu)) { amsbc = 1; /* TODO: get ddr type from bootloader and use 2 for LPDDR4 */