| Message ID | 20230302124819.686469-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/nvfw/acr: set wpr_generic_header_dump storage-class-specifier to static | expand |
Reviewed-by: Karol Herbst <kherbst@redhat.com> will push in a moment On Thu, Mar 2, 2023 at 1:48 PM Tom Rix <trix@redhat.com> wrote: > > gcc with W=1 reports > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous > prototype for ‘wpr_generic_header_dump’ [-Werror=missing-prototypes] > 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, > | ^~~~~~~~~~~~~~~~~~~~~~~ > > wpr_generic_header_dump is only used in acr.c, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > index 83a9c48bc58c..7ac90c495737 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c > @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr) > nvkm_debug(subdev, "\tstatus : %d\n", hdr->status); > } > > -void > +static void > wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr) > { > nvkm_debug(subdev, "wprGenericHeader\n"); > -- > 2.27.0 >
diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c index 83a9c48bc58c..7ac90c495737 100644 --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct wpr_header_v1 *hdr) nvkm_debug(subdev, "\tstatus : %d\n", hdr->status); } -void +static void wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct wpr_generic_header *hdr) { nvkm_debug(subdev, "wprGenericHeader\n");
gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ‘wpr_generic_header_dump’ [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~~~~~~~~~~~~~~~~~~~~~ wpr_generic_header_dump is only used in acr.c, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)