| Message ID | 20230308121718.2586933-1-guchun.chen@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path | expand |
On Wed, 08 Mar 2023, Guchun Chen <guchun.chen@amd.com> wrote: > In order to catch issues in other drivers to ensure proper call > sequence of polling function. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") How does an additional warning "fix" anything? > Reported-by: Bert Karwatzki <spasswolf@web.de> > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Guchun Chen <guchun.chen@amd.com> > --- > drivers/gpu/drm/drm_probe_helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 8127be134c39..85e0e80d4a52 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -852,6 +852,8 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > */ > void drm_kms_helper_poll_disable(struct drm_device *dev) > { > + WARN_ON(!dev->mode_config.poll_enabled); drm_WARN_ON() please. > + > if (dev->mode_config.poll_running) > drm_kms_helper_disable_hpd(dev);
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index 8127be134c39..85e0e80d4a52 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -852,6 +852,8 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); */ void drm_kms_helper_poll_disable(struct drm_device *dev) { + WARN_ON(!dev->mode_config.poll_enabled); + if (dev->mode_config.poll_running) drm_kms_helper_disable_hpd(dev);
In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Reported-by: Bert Karwatzki <spasswolf@web.de> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Guchun Chen <guchun.chen@amd.com> --- drivers/gpu/drm/drm_probe_helper.c | 2 ++ 1 file changed, 2 insertions(+)