| Message ID | 20230314080231.20212-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next,1/2] drm/arm/malidp: Use devm_platform_get_and_ioremap_resource() | expand |
On Tue, Mar 14, 2023 at 04:02:30PM +0800, Yang Li wrote: > According to commit 7945f929f1a7 ("drivers: provide > devm_platform_ioremap_resource()"), convert platform_get_resource(), > devm_ioremap_resource() to a single call to Use > devm_platform_ioremap_resource(), as this is exactly what this function > does. > > Since 'struct platform_device *pdev = to_platform_device(drm->dev)', > 'drm->dev' is equivalent to 'pdev->deva'. > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Thanks for cleaning this up! Best regards, Liviu > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index e3507dd6f82a..a86b317c1312 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -100,7 +100,6 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) > { > struct hdlcd_drm_private *hdlcd = drm_to_hdlcd_priv(drm); > struct platform_device *pdev = to_platform_device(drm->dev); > - struct resource *res; > u32 version; > int ret; > > @@ -115,8 +114,7 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) > atomic_set(&hdlcd->dma_end_count, 0); > #endif > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - hdlcd->mmio = devm_ioremap_resource(drm->dev, res); > + hdlcd->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(hdlcd->mmio)) { > DRM_ERROR("failed to map control registers area\n"); > ret = PTR_ERR(hdlcd->mmio); > -- > 2.20.1.7.g153144c >
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index e3507dd6f82a..a86b317c1312 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -100,7 +100,6 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) { struct hdlcd_drm_private *hdlcd = drm_to_hdlcd_priv(drm); struct platform_device *pdev = to_platform_device(drm->dev); - struct resource *res; u32 version; int ret; @@ -115,8 +114,7 @@ static int hdlcd_load(struct drm_device *drm, unsigned long flags) atomic_set(&hdlcd->dma_end_count, 0); #endif - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hdlcd->mmio = devm_ioremap_resource(drm->dev, res); + hdlcd->mmio = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(hdlcd->mmio)) { DRM_ERROR("failed to map control registers area\n"); ret = PTR_ERR(hdlcd->mmio);
According to commit 7945f929f1a7 ("drivers: provide devm_platform_ioremap_resource()"), convert platform_get_resource(), devm_ioremap_resource() to a single call to Use devm_platform_ioremap_resource(), as this is exactly what this function does. Since 'struct platform_device *pdev = to_platform_device(drm->dev)', 'drm->dev' is equivalent to 'pdev->deva'. Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)