diff mbox series

drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs

Message ID 20230316072647.406707-1-christian.koenig@amd.com (mailing list archive)
State New, archived
Headers show
Series drm/ttm: drop extra ttm_bo_put in ttm_bo_cleanup_refs | expand

Commit Message

Christian König March 16, 2023, 7:26 a.m. UTC 
That was accidentially left over when we switched to the delayed delete
worker.

Suggested-by: Matthew Auld <matthew.william.auld@gmail.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
Reported-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Matthew Auld March 16, 2023, 9:26 a.m. UTC | #1 
On Thu, 16 Mar 2023 at 07:26, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> That was accidentially left over when we switched to the delayed delete
> worker.
>
> Suggested-by: Matthew Auld <matthew.william.auld@gmail.com>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
> Reported-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Dave Airlie March 17, 2023, 5:44 a.m. UTC | #2 
On Thu, 16 Mar 2023 at 19:27, Matthew Auld
<matthew.william.auld@gmail.com> wrote:
>
> On Thu, 16 Mar 2023 at 07:26, Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
> >
> > That was accidentially left over when we switched to the delayed delete
> > worker.
> >
> > Suggested-by: Matthew Auld <matthew.william.auld@gmail.com>
> > Signed-off-by: Christian König <christian.koenig@amd.com>
> > Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
> > Reported-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> > Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>

I'm taking this directly into drm-fixes, please don't apply it to
drm-misc-fixes at all.

Dave.
Christian König March 17, 2023, 8:55 a.m. UTC | #3 
Am 17.03.23 um 06:44 schrieb Dave Airlie:
> On Thu, 16 Mar 2023 at 19:27, Matthew Auld
> <matthew.william.auld@gmail.com> wrote:
>> On Thu, 16 Mar 2023 at 07:26, Christian König
>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>> That was accidentially left over when we switched to the delayed delete
>>> worker.
>>>
>>> Suggested-by: Matthew Auld <matthew.william.auld@gmail.com>
>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>>> Fixes: ("9bff18d13473") drm/ttm: use per BO cleanup workers
>>> Reported-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>> Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> I'm taking this directly into drm-fixes, please don't apply it to
> drm-misc-fixes at all.

Ack and sorry for the noise.

Christian.

>
> Dave.
diff mbox series

Patch

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 459f1b4440da..6314653e91f7 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -294,8 +294,6 @@  static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo,
 	if (unlock_resv)
 		dma_resv_unlock(bo->base.resv);
 
-	ttm_bo_put(bo);
-
 	return 0;
 }