| Message ID | 20230327133848.5250-4-arthurgrillo@riseup.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Create tests for the drm_rect functions | expand |
Hi Arthur, On 3/27/23 10:38, Arthur Grillo wrote: > Insert test for the drm_rect_vscale() function, besides the test > for the usual case it also test for the exceptions. > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> > --- > drivers/gpu/drm/tests/drm_rect_test.c | 56 +++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/gpu/drm/tests/drm_rect_test.c > index c282e1cf9c30..a14da86ef435 100644 > --- a/drivers/gpu/drm/tests/drm_rect_test.c > +++ b/drivers/gpu/drm/tests/drm_rect_test.c > @@ -388,6 +388,59 @@ static void drm_test_rect_calc_hscale_negative_args(struct kunit *test) > KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); > } > > +static void drm_test_rect_calc_vscale(struct kunit *test) > +{ > + struct drm_rect src, dst; > + int scaling_factor; > + > + drm_rect_init(&src, 0, 0, 0, 2 << 16); > + drm_rect_init(&dst, 0, 0, 0, 1 << 16); > + What about the case that dst_h == 0? Best Regards, - Maíra Canal > + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); > + > + KUNIT_EXPECT_EQ(test, scaling_factor, 2); > +} > + > +static void drm_test_rect_calc_vscale_out_of_range(struct kunit *test) > +{ > + struct drm_rect src, dst; > + int scaling_factor; > + > + drm_rect_init(&src, 0, 0, 0, 10 << 16); > + drm_rect_init(&dst, 0, 0, 0, 1 << 16); > + > + scaling_factor = drm_rect_calc_vscale(&src, &dst, 3, 5); > + > + KUNIT_EXPECT_EQ(test, scaling_factor, -ERANGE); > + > + drm_rect_init(&src, 0, 0, 0, 2 << 16); > + drm_rect_init(&dst, 0, 0, 0, 1 << 16); > + > + scaling_factor = drm_rect_calc_vscale(&src, &dst, 3, 5); > + > + KUNIT_EXPECT_EQ(test, scaling_factor, -ERANGE); > +} > + > +static void drm_test_rect_calc_vscale_negative_args(struct kunit *test) > +{ > + struct drm_rect src, dst; > + int scaling_factor; > + > + drm_rect_init(&src, 0, 0, 0, -1 << 16); > + drm_rect_init(&dst, 0, 0, 0, 1 << 16); > + > + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); > + > + KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); > + > + drm_rect_init(&src, 0, 0, 0, 1 << 16); > + drm_rect_init(&dst, 0, 0, 0, -1 << 16); > + > + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); > + > + KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); > +} > + > static struct kunit_case drm_rect_tests[] = { > KUNIT_CASE(drm_test_rect_clip_scaled_div_by_zero), > KUNIT_CASE(drm_test_rect_clip_scaled_not_clipped), > @@ -397,6 +450,9 @@ static struct kunit_case drm_rect_tests[] = { > KUNIT_CASE(drm_test_rect_calc_hscale), > KUNIT_CASE(drm_test_rect_calc_hscale_out_of_range), > KUNIT_CASE(drm_test_rect_calc_hscale_negative_args), > + KUNIT_CASE(drm_test_rect_calc_vscale), > + KUNIT_CASE(drm_test_rect_calc_vscale_out_of_range), > + KUNIT_CASE(drm_test_rect_calc_vscale_negative_args), > { } > }; >
diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/gpu/drm/tests/drm_rect_test.c index c282e1cf9c30..a14da86ef435 100644 --- a/drivers/gpu/drm/tests/drm_rect_test.c +++ b/drivers/gpu/drm/tests/drm_rect_test.c @@ -388,6 +388,59 @@ static void drm_test_rect_calc_hscale_negative_args(struct kunit *test) KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); } +static void drm_test_rect_calc_vscale(struct kunit *test) +{ + struct drm_rect src, dst; + int scaling_factor; + + drm_rect_init(&src, 0, 0, 0, 2 << 16); + drm_rect_init(&dst, 0, 0, 0, 1 << 16); + + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); + + KUNIT_EXPECT_EQ(test, scaling_factor, 2); +} + +static void drm_test_rect_calc_vscale_out_of_range(struct kunit *test) +{ + struct drm_rect src, dst; + int scaling_factor; + + drm_rect_init(&src, 0, 0, 0, 10 << 16); + drm_rect_init(&dst, 0, 0, 0, 1 << 16); + + scaling_factor = drm_rect_calc_vscale(&src, &dst, 3, 5); + + KUNIT_EXPECT_EQ(test, scaling_factor, -ERANGE); + + drm_rect_init(&src, 0, 0, 0, 2 << 16); + drm_rect_init(&dst, 0, 0, 0, 1 << 16); + + scaling_factor = drm_rect_calc_vscale(&src, &dst, 3, 5); + + KUNIT_EXPECT_EQ(test, scaling_factor, -ERANGE); +} + +static void drm_test_rect_calc_vscale_negative_args(struct kunit *test) +{ + struct drm_rect src, dst; + int scaling_factor; + + drm_rect_init(&src, 0, 0, 0, -1 << 16); + drm_rect_init(&dst, 0, 0, 0, 1 << 16); + + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); + + KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); + + drm_rect_init(&src, 0, 0, 0, 1 << 16); + drm_rect_init(&dst, 0, 0, 0, -1 << 16); + + scaling_factor = drm_rect_calc_vscale(&src, &dst, 0, INT_MAX); + + KUNIT_EXPECT_EQ(test, scaling_factor, -EINVAL); +} + static struct kunit_case drm_rect_tests[] = { KUNIT_CASE(drm_test_rect_clip_scaled_div_by_zero), KUNIT_CASE(drm_test_rect_clip_scaled_not_clipped), @@ -397,6 +450,9 @@ static struct kunit_case drm_rect_tests[] = { KUNIT_CASE(drm_test_rect_calc_hscale), KUNIT_CASE(drm_test_rect_calc_hscale_out_of_range), KUNIT_CASE(drm_test_rect_calc_hscale_negative_args), + KUNIT_CASE(drm_test_rect_calc_vscale), + KUNIT_CASE(drm_test_rect_calc_vscale_out_of_range), + KUNIT_CASE(drm_test_rect_calc_vscale_negative_args), { } };
Insert test for the drm_rect_vscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> --- drivers/gpu/drm/tests/drm_rect_test.c | 56 +++++++++++++++++++++++++++ 1 file changed, 56 insertions(+)