From patchwork Tue Apr 4 01:28:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13199014 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A54C7C77B62 for ; Tue, 4 Apr 2023 01:28:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BE1510E2DA; Tue, 4 Apr 2023 01:28:43 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0325110E2B6 for ; Tue, 4 Apr 2023 01:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680571720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=teftSvf3j+oDEfh9blmwCCDYEJcHPfUL8pF7dJUM03o=; b=NqFZbJqifYaG7/Y9HcDCPiTkFjb9OkWhM9tDVMF1GfgHCF0tnw8+Q1nu1v4nNr8xHo3/fW HgdyU/9s3mbKX0nOG1RLcWDrRktvwr7RJO2GM9SMtOW4qpuqke2DWjXAndEFDY3ZLGH2oL gDo5gXAQuQAOs25HAZ/fYxZADt7QL4U= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-oNttiJ-pMxCtA2rfhiVs9A-1; Mon, 03 Apr 2023 21:28:38 -0400 X-MC-Unique: oNttiJ-pMxCtA2rfhiVs9A-1 Received: by mail-qv1-f69.google.com with SMTP id h7-20020a0cd807000000b005dd254e7babso13899529qvj.14 for ; Mon, 03 Apr 2023 18:28:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680571718; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=teftSvf3j+oDEfh9blmwCCDYEJcHPfUL8pF7dJUM03o=; b=OMvwqwZBC6GjSY/NffdvrAOIb8V3WWPo4wIUarmK6BwGTVluuNeQK/ifJmB5dVRJ7e 6/xuDCim/NSNTXIppqMfvHkxIbEM8Ujkmvi3TYYNl4iEORQv0RbSKhXKB1JQJebKlS/9 gbzhEfksNrdf0T/9i/w0bLgvP+NHXIwqz5CgglFok8WBD/CA/YpODvm/HFWG/4CSX1Ie lzDqaNLTYXDQWXpWsolicmWRCN9f3OGmld4XEq2/rp5fynHVk0PXFppzL41Hi1+Q7iWG Rw8AK2z3XemYnOat/i6b1wM7nWmV4CeTWYcPMvu3PHWoA3jOgZ2bK2ZFLWout1/4f2g0 oiRw== X-Gm-Message-State: AAQBX9eYVCrYBM97ho0J+F4Ukv86ru6Bf/TS6vBjosyMP+k41uBE3CyZ kC1k78BPimK1+5ZXBDZ3tbPuXpcgFAo9cTlu729RIlrAx7BkSIwg6M8YEpwRnjMOO1hKv1YCTWo mzqjOxrvl1Bmb6JRK/+cTu/WJ9lnx X-Received: by 2002:a05:622a:198f:b0:3b9:b70c:9697 with SMTP id u15-20020a05622a198f00b003b9b70c9697mr1012254qtc.5.1680571718498; Mon, 03 Apr 2023 18:28:38 -0700 (PDT) X-Google-Smtp-Source: AKy350bbiryGVTITqdtIsbZB0xVNKw9hfnyjZ3IusPT9JnYkHi5X/4j9GN4kCg0GViAYb2/AR5XwFA== X-Received: by 2002:a05:622a:198f:b0:3b9:b70c:9697 with SMTP id u15-20020a05622a198f00b003b9b70c9697mr1012244qtc.5.1680571718299; Mon, 03 Apr 2023 18:28:38 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id de27-20020a05620a371b00b007486d9fa1d7sm3185102qkb.95.2023.04.03.18.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 18:28:38 -0700 (PDT) From: Tom Rix To: bskeggs@redhat.com, kherbst@redhat.com, lyude@redhat.com, airlied@gmail.com, daniel@ffwll.ch, airlied@redhat.com Subject: [PATCH] drm/nouveau/disp: set varaiable gv100_disp_core_mthd_base storage-class-specifier to static Date: Mon, 3 Apr 2023 21:28:34 -0400 Message-Id: <20230404012834.1914225-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Rix Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" smatch reports drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:610:1: warning: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? This variable is only used in one file so it should be static. Signed-off-by: Tom Rix --- drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c index 115d0997fd62..4ebc030e40d1 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c @@ -606,7 +606,7 @@ gv100_disp_curs = { .user = 73, }; -const struct nvkm_disp_mthd_list +static const struct nvkm_disp_mthd_list gv100_disp_core_mthd_base = { .mthd = 0x0000, .addr = 0x000000,