From patchwork Tue Apr 4 18:41:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Grillo X-Patchwork-Id: 13200884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 391FEC6FD1D for ; Tue, 4 Apr 2023 18:42:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 610F010E765; Tue, 4 Apr 2023 18:42:30 +0000 (UTC) Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44D9010E765 for ; Tue, 4 Apr 2023 18:42:28 +0000 (UTC) Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4Prc7l3x6Yz9swt; Tue, 4 Apr 2023 18:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1680633747; bh=JmUJQY0/PZQ8w3L1Kjq9ObQwASlO1vRd5wgD3xC2GSA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p4OofIeY+xHQw3+uEgv/1IhUQp0PjXTfYsOnnpuFXRAeZd5/KoJJjLmJlXBFMrUJu u2m+yFhtit8DxgC4YRJwGGI/H3W1d00fs5+gFIF6/nwVSaYq+5J41ILYqGwqUkZx+U X+/vTEGlkw58hteu5VNaZGe8JN4QXPy5IrLEUW78= X-Riseup-User-ID: 2123507E217BDE31779E64F4AE1355E3E8B8D02F1B53FF961238439F3C5E208D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4Prc7g2pS9z1yNK; Tue, 4 Apr 2023 18:42:23 +0000 (UTC) From: Arthur Grillo To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 3/5] drm/tests: Add test cases for drm_rect_calc_vscale() Date: Tue, 4 Apr 2023 15:41:56 -0300 Message-Id: <20230404184158.26290-4-arthurgrillo@riseup.net> In-Reply-To: <20230404184158.26290-1-arthurgrillo@riseup.net> References: <20230404184158.26290-1-arthurgrillo@riseup.net> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: carlos.craveiro@usp.br, tales.aparecida@gmail.com, dlatypov@google.com, javierm@redhat.com, mairacanal@riseup.net, maxime@cerno.tech, andrealmeid@riseup.net, Arthur Grillo , matheus.vieira.g@usp.br Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 59 +++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/gpu/drm/tests/drm_rect_test.c index 293e5c48bb32..30bb4d84f3a0 100644 --- a/drivers/gpu/drm/tests/drm_rect_test.c +++ b/drivers/gpu/drm/tests/drm_rect_test.c @@ -414,6 +414,64 @@ static void drm_test_rect_calc_hscale(struct kunit *test) KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); } +static const struct drm_rect_scale_case drm_rect_vscale_cases[] = { + { + .name = "normal use", + .src = DRM_RECT_INIT(0, 0, 0, 2 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, 1 << 16), + .min_range = 0, .max_range = INT_MAX, + .expected_scaling_factor = 2, + }, + { + .name = "out of max range", + .src = DRM_RECT_INIT(0, 0, 0, 10 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, 1 << 16), + .min_range = 3, .max_range = 5, + .expected_scaling_factor = -ERANGE, + }, + { + .name = "out of min range", + .src = DRM_RECT_INIT(0, 0, 0, 2 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, 1 << 16), + .min_range = 3, .max_range = 5, + .expected_scaling_factor = -ERANGE, + }, + { + .name = "zero dst height", + .src = DRM_RECT_INIT(0, 0, 0, 2 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, 0 << 16), + .min_range = 0, .max_range = INT_MAX, + .expected_scaling_factor = 0, + }, + { + .name = "negative src height", + .src = DRM_RECT_INIT(0, 0, 0, -1 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, 1 << 16), + .min_range = 0, .max_range = INT_MAX, + .expected_scaling_factor = -EINVAL, + }, + { + .name = "negative dst height", + .src = DRM_RECT_INIT(0, 0, 0, 1 << 16), + .dst = DRM_RECT_INIT(0, 0, 0, -1 << 16), + .min_range = 0, .max_range = INT_MAX, + .expected_scaling_factor = -EINVAL, + }, +}; + +KUNIT_ARRAY_PARAM(drm_rect_vscale, drm_rect_vscale_cases, drm_rect_scale_case_desc); + +static void drm_test_rect_calc_vscale(struct kunit *test) +{ + const struct drm_rect_scale_case *params = test->param_value; + int scaling_factor; + + scaling_factor = drm_rect_calc_vscale(¶ms->src, ¶ms->dst, + params->min_range, params->max_range); + + KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor); +} + static struct kunit_case drm_rect_tests[] = { KUNIT_CASE(drm_test_rect_clip_scaled_div_by_zero), KUNIT_CASE(drm_test_rect_clip_scaled_not_clipped), @@ -421,6 +479,7 @@ static struct kunit_case drm_rect_tests[] = { KUNIT_CASE(drm_test_rect_clip_scaled_signed_vs_unsigned), KUNIT_CASE_PARAM(drm_test_rect_intersect, drm_rect_intersect_gen_params), KUNIT_CASE_PARAM(drm_test_rect_calc_hscale, drm_rect_hscale_gen_params), + KUNIT_CASE_PARAM(drm_test_rect_calc_vscale, drm_rect_vscale_gen_params), { } };