From patchwork Tue Apr 4 19:40:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 13200928 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EF00C6FD1D for ; Tue, 4 Apr 2023 19:40:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7876410E79B; Tue, 4 Apr 2023 19:40:53 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A5ED10E791 for ; Tue, 4 Apr 2023 19:40:50 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id y4so135166506edo.2 for ; Tue, 04 Apr 2023 12:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1680637248; x=1683229248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HaT5ndE8pysE8xXupUICEr52//Ceqqz0gTn56+JWqvc=; b=b2ik949ITDajIlctCc1vBc0ULiEY5E6yotv8r9ogUFfQH9nI5bG+rwxpTx37Z952x4 zNutqTfFsNpWeO3YoU16PklObobaS2RI1pG2gSpPXCCKx3xI0VKOOad7gLs1nDcPe3oB NBYo1XxcqKBQC66r+PVksCdhRwklF5N2/lj9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680637248; x=1683229248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HaT5ndE8pysE8xXupUICEr52//Ceqqz0gTn56+JWqvc=; b=5PMF7zDUnnxCTkeXS8NbqtAlngGkv+CrE/d6bVc2eZuRxs6YeMigCeVWkEjTt9JoSY p+0auSPTkdnIUL2/d1cZHTDff8qQuZYhhHWfN8SBUgKFmLW/GYezabty3+fKTg0RJgcv vLBNnh3CqVquAYQBkvVsGABHOrym6YZnyFbfC8rz1iVeUDmLiEk1ZWxV3EqywkDvSmCq Ugq1RFD8FV4fBGIYvx1l3vtQT0pGzaZVJfwDlX7UjHWya2gDZEh4/xDGNEK/VK/+arVN 8EcaFb4IdGy0SqQJaJIruHLNhsqxjczIuqC4iQSj+at2h6BYQB67JGMRpKDQQqrjiwdD Vvqw== X-Gm-Message-State: AAQBX9esRzRK38N40fmr8ZFN2lJwl4Ch1Pi5yd6xJmCbe/AdWY27sox8 XVwBrbzT6S994YxJfbXdrLh8zOIYneNQcW3T8kk= X-Google-Smtp-Source: AKy350acmCVMfSzMccJ+1LVre1XMFOyzteJhbrKeoHuS69A5jCdZ5Puqr2wnGYHjcJlqYPjAcNQgSg== X-Received: by 2002:a17:906:518e:b0:931:5145:c51f with SMTP id y14-20020a170906518e00b009315145c51fmr777602ejk.4.1680637248617; Tue, 04 Apr 2023 12:40:48 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-33.fiber7.init7.net. [212.51.149.33]) by smtp.gmail.com with ESMTPSA id xb7-20020a170907070700b00948c2f245a9sm2472802ejb.110.2023.04.04.12.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 12:40:48 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/3] drm/fb-helper: drop redundant pixclock check from drm_fb_helper_set_par() Date: Tue, 4 Apr 2023 21:40:37 +0200 Message-Id: <20230404194038.472803-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230404194038.472803-1-daniel.vetter@ffwll.ch> References: <20230404194038.472803-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Thomas Zimmermann , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The fb_check_var hook is supposed to validate all this stuff. Any errors from fb_set_par are considered driver/hw issues and resulting in dmesg warnings. Luckily we do fix up the pixclock already, so this is all fine. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index eb4ece3e0027..b9696d13a741 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1647,11 +1647,6 @@ int drm_fb_helper_set_par(struct fb_info *info) if (oops_in_progress) return -EBUSY; - if (var->pixclock != 0) { - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); - return -EINVAL; - } - /* * Normally we want to make sure that a kms master takes precedence over * fbdev, to avoid fbdev flickering and occasionally stealing the