| Message ID | 20230406195818.1958162-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: set variables aperture_default_system and context0_default_system storage-class-specifier to static | expand |
On 4/6/23 15:58, Tom Rix wrote: > smatch reports > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol > 'aperture_default_system' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol > 'context0_default_system' was not declared. Should it be static? > > These variables are only used in one file so should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> Applied, thanks! > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c > index a142a00bc432..bf399819ca80 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c > @@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp) > return false; > } > > -uint32_t aperture_default_system = 1; > -uint32_t context0_default_system; /* = 0;*/ > +static uint32_t aperture_default_system = 1; > +static uint32_t context0_default_system; /* = 0;*/ > > static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp, > struct vm_system_aperture_param *apt)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c index a142a00bc432..bf399819ca80 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c @@ -755,8 +755,8 @@ bool hubp1_is_flip_pending(struct hubp *hubp) return false; } -uint32_t aperture_default_system = 1; -uint32_t context0_default_system; /* = 0;*/ +static uint32_t aperture_default_system = 1; +static uint32_t context0_default_system; /* = 0;*/ static void hubp1_set_vm_system_aperture_settings(struct hubp *hubp, struct vm_system_aperture_param *apt)
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:758:10: warning: symbol 'aperture_default_system' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:759:10: warning: symbol 'context0_default_system' was not declared. Should it be static? These variables are only used in one file so should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)