diff mbox series

[1/6] drm/uapi: Document CTM matrix better

Message ID 20230411222931.15127-2-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: CTM stuff mostly | expand

Commit Message

Ville Syrjälä April 11, 2023, 10:29 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Document in which order the CTM matrix elements are stored.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 include/uapi/drm/drm_mode.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Xaver Hugl April 27, 2023, 10:31 p.m. UTC | #1 
I can't say anything about the other commits in this series, but
"Document in which order the CTM matrix elements are stored" is
Reviewed-by: Xaver Hugl <xaver.hugl@gmail.com>
Simon Ser April 28, 2023, 9:27 a.m. UTC | #2 
Acked-by: Simon Ser <contact@emersion.fr>
Ville Syrjälä April 28, 2023, 1:39 p.m. UTC | #3 
On Fri, Apr 28, 2023 at 12:31:10AM +0200, Xaver Hugl wrote:
> I can't say anything about the other commits in this series, but
> "Document in which order the CTM matrix elements are stored" is
> Reviewed-by: Xaver Hugl <xaver.hugl@gmail.com>

Thanks for the review+ack. Pushed to drm-misc-next.
diff mbox series

Patch

diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index 46becedf5b2f..43691058d28f 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -834,6 +834,11 @@  struct drm_color_ctm {
 	/*
 	 * Conversion matrix in S31.32 sign-magnitude
 	 * (not two's complement!) format.
+	 *
+	 * out   matrix    in
+	 * |R|   |0 1 2|   |R|
+	 * |G| = |3 4 5| x |G|
+	 * |B|   |6 7 8|   |B|
 	 */
 	__u64 matrix[9];
 };