| Message ID | 20230416131632.31673-2-aweber.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Samsung S6D7AA0 panel controller driver | expand |
On Sun, Apr 16, 2023 at 03:16:30PM +0200, Artur Weber wrote: > Add bindings for the S6D7AA0 LCD panel controller, including the > S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family > of tablets. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- > Changed in v2: > - Updated commit message > - Applied suggestions from Krzysztof Kozlowski > Changed in v3: > - Correctly applied suggestions > --- > .../display/panel/samsung,s6d7aa0.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > new file mode 100644 > index 000000000000..079e2b3a9eaf > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,s6d7aa0.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S6D7AA0 MIPI-DSI LCD panel controller > + > +maintainers: > + - Artur Weber <aweber.kernel@gmail.com> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,s6d7aa0-lsl080al02 > + > + reg: true > + reset-gpios: true > + backlight: true > + > + enable-supply: > + description: Enable supply Comments on v1 apply here. Rob
Hi Artur, thanks for your patch! On Sun, Apr 16, 2023 at 3:16 PM Artur Weber <aweber.kernel@gmail.com> wrote: > Add bindings for the S6D7AA0 LCD panel controller, including the > S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family > of tablets. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> (...) > + reset-gpios: true (...) > + reset-gpios = <&gpf0 4 GPIO_ACTIVE_LOW>; Since reset-gpios is always active low, add a description: to reset-gpios saying that it should nominally be tagged GPIO_ACTIVE_LOW. Yours. Linus Walleij
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml new file mode 100644 index 000000000000..079e2b3a9eaf --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,s6d7aa0.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S6D7AA0 MIPI-DSI LCD panel controller + +maintainers: + - Artur Weber <aweber.kernel@gmail.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,s6d7aa0-lsl080al02 + + reg: true + reset-gpios: true + backlight: true + + enable-supply: + description: Enable supply + +required: + - compatible + - reg + - reset-gpios + - backlight + - enable-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "samsung,s6d7aa0-lsl080al02"; + reg = <0>; + reset-gpios = <&gpf0 4 GPIO_ACTIVE_LOW>; + backlight = <&backlight>; + enable-supply = <&lcd_enable_supply>; + }; + }; + +...
Add bindings for the S6D7AA0 LCD panel controller, including the S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family of tablets. Signed-off-by: Artur Weber <aweber.kernel@gmail.com> --- Changed in v2: - Updated commit message - Applied suggestions from Krzysztof Kozlowski Changed in v3: - Correctly applied suggestions --- .../display/panel/samsung,s6d7aa0.yaml | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml