| Message ID | 20230426111838.728441-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: set variable custom_backlight_curve0 storage-class-specifier to static | expand |
On 4/26/23 07:18, Tom Rix wrote: > smatch reports > drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31: > warning: symbol 'custom_backlight_curve0' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static > Signed-off-by: Tom Rix <trix@redhat.com> Applied, thanks! > --- > drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c > index 68d95b92df76..30349881a283 100644 > --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c > +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c > @@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = { > abm_settings_config2, > }; > > -const struct dm_bl_data_point custom_backlight_curve0[] = { > +static const struct dm_bl_data_point custom_backlight_curve0[] = { > {2, 14}, {4, 16}, {6, 18}, {8, 21}, {10, 23}, {12, 26}, {14, 29}, {16, 32}, {18, 35}, > {20, 38}, {22, 41}, {24, 44}, {26, 48}, {28, 52}, {30, 55}, {32, 59}, {34, 62}, > {36, 67}, {38, 71}, {40, 75}, {42, 80}, {44, 84}, {46, 88}, {48, 93}, {50, 98},
diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c index 68d95b92df76..30349881a283 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c @@ -116,7 +116,7 @@ static const struct abm_parameters * const abm_settings[] = { abm_settings_config2, }; -const struct dm_bl_data_point custom_backlight_curve0[] = { +static const struct dm_bl_data_point custom_backlight_curve0[] = { {2, 14}, {4, 16}, {6, 18}, {8, 21}, {10, 23}, {12, 26}, {14, 29}, {16, 32}, {18, 35}, {20, 38}, {22, 41}, {24, 44}, {26, 48}, {28, 52}, {30, 55}, {32, 59}, {34, 62}, {36, 67}, {38, 71}, {40, 75}, {42, 80}, {44, 84}, {46, 88}, {48, 93}, {50, 98},
smatch reports drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:119:31: warning: symbol 'custom_backlight_curve0' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)